OCPBUGS-55668: ipam, virt: remove the PersistentIPsForVirt FG

[maiqueb]

The feature has been GA'ed in OpenShift 4.18, hence, no need to still carry this feat gate around - the feature will be always enabled.

[openshift-ci]

Hello @maiqueb! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: maiqueb
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci-robot]

@maiqueb: This pull request references Jira Issue OCPBUGS-55668, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.20.0) matches configured target version for branch (4.20.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @anuragthehatter

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

The feature has been GA'ed in OpenShift 4.18, hence, no need to still carry this feat gate around - the feature will be always enabled.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[JoelSpeed]

@maiqueb What is the appropriate payload job that leverages this feature gate? We need to run it to verify that no operators are still trying to look at the gate

[JoelSpeed]

@maiqueb Never mind, I can see from https://prow.ci.openshift.org/view/gs/test-platform-results/pr-logs/pull/openshift_api/2309/pull-ci-openshift-api-master-e2e-upgrade/1919319352989978624 that the network operator is still looking at the gate. Please resolve this first.

[openshift-ci]

@maiqueb: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-upgrade	b3ece63	link	true	/test e2e-upgrade
ci/prow/e2e-aws-ovn-techpreview	b3ece63	link	true	/test e2e-aws-ovn-techpreview
ci/prow/e2e-gcp	b3ece63	link	false	/test e2e-gcp
ci/prow/e2e-aws-serial-techpreview	b3ece63	link	true	/test e2e-aws-serial-techpreview
ci/prow/minor-e2e-upgrade-minor	b3ece63	link	true	/test minor-e2e-upgrade-minor
ci/prow/e2e-aws-ovn-hypershift	b3ece63	link	true	/test e2e-aws-ovn-hypershift
ci/prow/e2e-upgrade-out-of-change	b3ece63	link	true	/test e2e-upgrade-out-of-change
ci/prow/okd-scos-e2e-aws-ovn	b3ece63	link	false	/test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-hypershift-conformance	b3ece63	link	true	/test e2e-aws-ovn-hypershift-conformance
ci/prow/e2e-aws-ovn	b3ece63	link	true	/test e2e-aws-ovn
ci/prow/e2e-azure	b3ece63	link	false	/test e2e-azure
ci/prow/e2e-aws-serial	b3ece63	link	true	/test e2e-aws-serial
ci/prow/e2e-aws-serial-2of2	b3ece63	link	true	/test e2e-aws-serial-2of2
ci/prow/e2e-aws-serial-1of2	b3ece63	link	true	/test e2e-aws-serial-1of2
ci/prow/e2e-aws-serial-techpreview-1of2	b3ece63	link	true	/test e2e-aws-serial-techpreview-1of2
ci/prow/e2e-aws-serial-techpreview-2of2	b3ece63	link	true	/test e2e-aws-serial-techpreview-2of2

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.