Skip to content

IR-523: setting read only root filesystem #1198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

ricardomaraschini
Copy link
Contributor

set the root filesystem as readonly for:

  • the operator deployment.
  • the nodeca daemonset.
  • the image registry deployment.
  • the pruner cronjob.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 27, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Mar 27, 2025

@ricardomaraschini: This pull request references IR-455 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the epic to target the "4.19.0" version, but no target version was set.

In response to this:

set the root filesystem as readonly for:

  • the operator deployment.
  • the nodeca daemonset.
  • the image registry deployment.
  • the pruner cronjob.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2025
Copy link
Contributor

openshift-ci bot commented Mar 27, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ricardomaraschini
Copy link
Contributor Author

/test all

Copy link
Contributor

openshift-ci bot commented Mar 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ricardomaraschini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 27, 2025
@ricardomaraschini
Copy link
Contributor Author

/retest

@ricardomaraschini
Copy link
Contributor Author

/retest

@ricardomaraschini
Copy link
Contributor Author

/retest

set the root filesystem as readonly for:

- the operator deployment.
- the nodeca daemonset.
- the image registry deployment.
- the pruner cronjob.

the operator requires access to /tmp so this directory is not mounted
out of an `emptyDir`.
@ricardomaraschini ricardomaraschini changed the title IR-455: setting read only root filesystem IR-523: setting read only root filesystem Apr 8, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 8, 2025

@ricardomaraschini: This pull request references IR-523 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

set the root filesystem as readonly for:

  • the operator deployment.
  • the nodeca daemonset.
  • the image registry deployment.
  • the pruner cronjob.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ricardomaraschini
Copy link
Contributor Author

/jira refresh

@ricardomaraschini ricardomaraschini marked this pull request as ready for review April 8, 2025 07:40
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 8, 2025

@ricardomaraschini: This pull request references IR-523 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 8, 2025
@openshift-ci openshift-ci bot requested a review from flavianmissi April 8, 2025 07:40
@ricardomaraschini
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Apr 8, 2025

@ricardomaraschini: This pull request references IR-523 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ricardomaraschini
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Apr 8, 2025

@ricardomaraschini: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift 2ba9c4a link true /test e2e-hypershift
ci/prow/e2e-aws-operator 2ba9c4a link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ricardomaraschini
Copy link
Contributor Author

I am closing this one in order to avoid confusion. This was just an attempt at addressing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants