Skip to content

ODC-7790: Remove ODO download link #987

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ODC-7790: Remove ODO download link #987

wants to merge 1 commit into from

Conversation

vikram-raj
Copy link
Member

ODO has been deprecated, so removing the ODO download link from the OCP Command Line Tools

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 12, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 12, 2025 •
edited by openshift-ci bot
Loading

@vikram-raj: This pull request references ODC-7790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

ODO has been deprecated, so removing the ODO download link from the OCP Command Line Tools

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from jhadvig and TheRealJon May 12, 2025 10:28
@vikram-raj
Copy link
Member Author

/retest

@vikram-raj
Copy link
Member Author

/cc @spadgett

@openshift-ci openshift-ci bot requested a review from spadgett May 14, 2025 05:53
@vikram-raj
Copy link
Member Author

/retest

jhadvig
jhadvig approved these changes May 16, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jhadvig
Copy link
Member

jhadvig commented May 16, 2025

/approve
/retest

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 16, 2025
@vikram-raj
Copy link
Member Author

/label docs-approved
/label px-approved

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels May 16, 2025
@sanketpathak
Copy link

Verified on a cluster, odo cli is not present in the cluster

Screenshot From 2025-05-16 16-59-02

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 16, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 16, 2025 •
edited by openshift-ci bot
Loading

@vikram-raj: This pull request references ODC-7790 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

ODO has been deprecated, so removing the ODO download link from the OCP Command Line Tools

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d9aa31b and 2 for PR HEAD a4d3d25 in total

4 similar comments
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d9aa31b and 2 for PR HEAD a4d3d25 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d9aa31b and 2 for PR HEAD a4d3d25 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d9aa31b and 2 for PR HEAD a4d3d25 in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d9aa31b and 2 for PR HEAD a4d3d25 in total

@vikram-raj
Copy link
Member Author

/retest

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d9aa31b and 2 for PR HEAD a4d3d25 in total

1 similar comment
@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d9aa31b and 2 for PR HEAD a4d3d25 in total

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 21, 2025
jhadvig
jhadvig approved these changes May 21, 2025
View reviewed changes
Copy link
Member

@jhadvig jhadvig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to remove the condition first.
/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 21, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhadvig, vikram-raj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vikram-raj
Copy link
Member Author

Here is the PR to remove the condition openshift/origin#29835

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d9aa31b and 2 for PR HEAD 8207afb in total

@vikram-raj
Copy link
Member Author

/hold

This PR needs to go in first openshift/origin#29835

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 21, 2025
@jhadvig jhadvig mentioned this pull request May 21, 2025
Open
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 21, 2025

@vikram-raj: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-ovn 8207afb link true /test e2e-gcp-ovn
ci/prow/okd-scos-e2e-aws-ovn 8207afb link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-single-node 8207afb link false /test e2e-aws-ovn-single-node

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig approved these changes

@TheRealJon TheRealJon Awaiting requested review from TheRealJon

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs-approved Signifies that Docs has signed off on this PR jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vikram-raj @openshift-ci-robot @jhadvig @sanketpathak