Skip to content

OCPBUGS-56148: Fix '/metrics' endpoint token review to handle interna… #15127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2025
Merged

OCPBUGS-56148: Fix '/metrics' endpoint token review to handle interna… #15127

merged 2 commits into from
Jun 7, 2025

Conversation

TheRealJon
Copy link
Member

…l prometheus scrape requests

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Jun 4, 2025
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: This pull request references Jira Issue OCPBUGS-56148, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sanketpathak

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

…l prometheus scrape requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added component/backend Related to backend approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 4, 2025
@TheRealJon TheRealJon changed the title [WIP] OCPBUGS-56148: Fix '/metrics' endpoint token review to handle interna… OCPBUGS-56148: Fix '/metrics' endpoint token review to handle interna… Jun 4, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 4, 2025
@TheRealJon
Copy link
Member Author

/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

@openshift-cherrypick-robot
Copy link

@TheRealJon: once the present PR merges, I will cherry-pick it on top of release-4.17, release-4.18, release-4.19 in new PRs and assign them to you.

In response to this:

/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@TheRealJon TheRealJon requested review from spadgett and removed request for rhamilto and sanketpathak June 4, 2025 19:07
spadgett
spadgett reviewed Jun 4, 2025
View reviewed changes
jhadvig
jhadvig reviewed Jun 4, 2025
View reviewed changes
@TheRealJon
Copy link
Member Author

/label tide/merge-method-squash

@openshift-ci openshift-ci bot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Jun 4, 2025
spadgett
spadgett approved these changes Jun 4, 2025
View reviewed changes
Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TheRealJon Let's see if we can add some test automation in a follow up. Thanks!

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 4, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: spadgett, TheRealJon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d2e9247 and 2 for PR HEAD 05124cc in total

@invincibleJai
Copy link
Member

/retest

1 similar comment
@TheRealJon
Copy link
Member Author

/retest

@TheRealJon
Copy link
Member Author

/jira backport release-4.19,release-4.18,release-4.17

@openshift-ci-robot
Copy link
Contributor

@TheRealJon: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.19
/cherrypick release-4.18
/cherrypick release-4.17

In response to this:

/jira backport release-4.19,release-4.18,release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@openshift-ci-robot: once the present PR merges, I will cherry-pick it on top of release-4.17, release-4.18, release-4.19 in new PRs and assign them to you.

In response to this:

@TheRealJon: The following backport issues have been created:

Queuing cherrypicks to the requested branches to be created after this PR merges:
/cherrypick release-4.19
/cherrypick release-4.18
/cherrypick release-4.17

In response to this:

/jira backport release-4.19,release-4.18,release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b8f330c and 1 for PR HEAD 05124cc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD b8f330c and 2 for PR HEAD 05124cc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD bcd1b01 and 1 for PR HEAD 05124cc in total

@openshift-ci-robot
Copy link
Contributor

/retest-required

Remaining retests: 0 against base HEAD d9e88f4 and 0 for PR HEAD 05124cc in total

@openshift-ci-robot
Copy link
Contributor

/hold

Revision 05124cc was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2025
@spadgett
Copy link
Member

spadgett commented Jun 7, 2025

/retest
/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Jun 7, 2025

@TheRealJon: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit e4785dd into openshift:main Jun 7, 2025
7 checks passed
@openshift-ci-robot
Copy link
Contributor

@TheRealJon: Jira Issue OCPBUGS-56148: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-56148 has not been moved to the MODIFIED state.

In response to this:

…l prometheus scrape requests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link

@TheRealJon: new pull request created: #15152

In response to this:

/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 7, 2025
Merged
@openshift-cherrypick-robot
Copy link

@TheRealJon: new pull request created: #15153

In response to this:

/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 7, 2025
Merged
@openshift-cherrypick-robot
Copy link

@TheRealJon: new pull request created: #15154

In response to this:

/cherry-pick release-4.19
/cherry-pick release-4.18
/cherry-pick release-4.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jun 7, 2025
Merged
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-console
This PR has been included in build openshift-enterprise-console-container-v4.20.0-202506072256.p0.ge4785dd.assembly.stream.el9.
All builds following this will include this PR.

@TheRealJon TheRealJon deleted the OCPBUGS-56148 branch June 9, 2025 04:27
clarku pushed a commit to clarku/console that referenced this pull request Jun 10, 2025
@TheRealJon
OCPBUGS-56148: Fix '/metrics' endpoint token review to handle interna… (
2ebdeb4 
openshift#15127)

* OCPBUGS-56148: Fix '/metrics' endpoint token review to handle internal prometheus scrape requests

* address feedback
@TheRealJon
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@TheRealJon: Jira Issue OCPBUGS-56148: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-56148 has not been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon
Copy link
Member Author

/jira refresh

@openshift-ci-robot
Copy link
Contributor

@TheRealJon: Jira Issue OCPBUGS-56148: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-56148 has been moved to the MODIFIED state.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@TheRealJon TheRealJon mentioned this pull request Jun 12, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhadvig jhadvig jhadvig left review comments

@spadgett spadgett spadgett approved these changes

Assignees

@spadgett spadgett

@jhadvig jhadvig

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/backend Related to backend jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@TheRealJon @openshift-ci-robot @openshift-cherrypick-robot @spadgett @invincibleJai @openshift-bot @jhadvig