cleanup assisted installer bare metal validations enhancement #393
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
|
/cc @hardys @romfreiman I missed a few of your comments on #388 before I removed the hold and let it merge |
|
/assign @hardys |
russellb
requested changes
Sep 1, 2020
There was a problem hiding this comment.
@dhellmann the updates look trivial, but I see it now has a conflict. Once you rebase this, ping me and I'll merge it.
fix some review comments missed before openshift#388 merged Signed-off-by: Doug Hellmann <[email protected]>
dhellmann
force-pushed
the
assisted-installer-validations-2
branch
from
4c4d803 to
a2d893f
Compare
|
@russellb this has been rebased |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, russellb The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix some review comments missed before #388 merged