Bug 2115821: Fix controller metrics port #278
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci
bot
added
bugzilla/severity-high
|
@mrogers950: This pull request references Bugzilla bug 2115821, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mrogers950 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/bugzilla refresh |
openshift-ci
bot
added
bugzilla/valid-bug
|
@mrogers950: This pull request references Bugzilla bug 2115821, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
rhmdnd
reviewed
Aug 9, 2022
We could add a test that curls against the endpoint to check that its running (we already CI test the custom metrics). But this would really be testing that controller-runtime started the default metrics listener. not sure that is too useful. |
|
Hm, the bundle jobs fail like: |
|
/retest |
|
/bugzilla cc-qa |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
/test all |
|
/retest |
- Run the controller-runtime metrics (controller workload stats) on port 8383. - Remove the service endpoint for http-metrics. This was previously an additional metrics endpoint provided by operator-sdk, but was only useful for proxy programs. controller-runtime now only provides controller workqueue metrics. - Ensure the metrics service is updated on operator startup. In turn this will update the ServiceMonitor for new changes to the service endpoints.
|
/retest |
|
We're just referencing this here as related art, right? We don't have a CO specific bug, do we (I couldn't find one)? |
rhmdnd
reviewed
Aug 24, 2022
|
@mrogers950: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mrogers950: All pull requests linked via external trackers have merged: Bugzilla bug 2115821 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: https://bugzilla.redhat.com/show_bug.cgi?id=2115821