Skip to content

Release v1.0.0 #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2022
Merged

Release v1.0.0 #300

merged 1 commit into from
Nov 29, 2022

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Nov 22, 2022

No description provided.

@openshift-ci openshift-ci bot requested review from jhrozek and mrogers950 November 22, 2022 16:16
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 22, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 22, 2022
@rhmdnd
Copy link
Contributor Author

rhmdnd commented Nov 22, 2022

/retest

@@ -19,10 +19,12 @@ metadata:
]
capabilities: Seamless Upgrades
categories: Monitoring,Security
olm.skipRange: '>=0.1.6 <0.1.32'
olm.skipRange: '>=0.1.6 <1.0.0'
Copy link
Contributor Author

@rhmdnd rhmdnd Nov 22, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note for other reviewers.

This allows someone to upgrade directly to 1.0.0, which is fine since 1.0.0 is technically backwards compatible with 0.1.32. Even though 1.0.0 is technically a major version bump, it doesn't change how it's used or deployed so a direct upgrade should be safe.

If or when we release FIO 2.0.0, we'll need to update the skipRange so that 1.0.0 is the lower bound, but that will be a ways out (we don't actually know when that would happen). We may not be supporting any 0.1.* releases at that point.

@mrogers950
Copy link
Contributor

/lgtm

@mrogers950
Copy link
Contributor

/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 22, 2022
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 9ab797e and 2 for PR HEAD 66d330e in total

@mrogers950
Copy link
Contributor

/retest

@mrogers950
Copy link
Contributor

I'm expecting e2e-bundle-aws-upgrade to fail.

@rhmdnd
Copy link
Contributor Author

rhmdnd commented Nov 29, 2022

Manually updated the upgrade versions here openshift/release#34279 but there are still some issues with the upgrade testing scenario.

We'll have to merge this through like we did with 0.1.32.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 29, 2022

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 692689d into master Nov 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants