Skip to content

Update make target for OPM #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Update make target for OPM #338

wants to merge 1 commit into from

Conversation

Vincent056
Copy link
Contributor

This updates make target for OPM version, the version variable should not be used here as this is a operator version

@openshift-ci openshift-ci bot requested review from jhrozek and xiaojiey April 7, 2023 03:42
@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2023
@Vincent056
Copy link
Contributor Author

/hold
We should hold this until #334 is merged

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2023
@Vincent056 Vincent056 removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 31, 2023
@Vincent056
Update make target for OPM
55d1402 
This updates make target for OPM version, the version variable should not be used here as this is a operator version
jhrozek
jhrozek approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@jhrozek jhrozek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jhrozek jhrozek added qe-approved Signifies that QE has signed off on this PR docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels Jun 1, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 1, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jhrozek, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD af6e8f1 and 2 for PR HEAD 55d1402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD df11364 and 1 for PR HEAD 55d1402 in total

@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e42133d and 0 for PR HEAD 55d1402 in total

@openshift-ci-robot
Copy link

/hold

Revision 55d1402 was retested 3 times: holding

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2023
@Vincent056
Copy link
Contributor Author

/retest

@rhmdnd
Copy link
Contributor

rhmdnd commented Jul 21, 2023

/retest

Issues getting an AWS cluster.

rhmdnd
rhmdnd reviewed Jul 21, 2023
View reviewed changes
Makefile
@@ -60,7 +60,7 @@ export NAMESPACE=openshift-file-integrity
SDK_BIN?=
SDK_VERSION?=1.27.0
# Ideally this should align with SDK_VERSION, but for now it needs to be newer.
OPM_VERSION?=$(VERSION)
OPM_VERSION?=1.26.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the significance of 1.26.5?

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jul 21, 2023

@Vincent056: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Vincent056 Vincent056 closed this Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhmdnd rhmdnd rhmdnd left review comments

@jhrozek jhrozek jhrozek approved these changes

@xiaojiey xiaojiey Awaiting requested review from xiaojiey

Assignees

@jhrozek jhrozek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Vincent056 @openshift-ci-robot @rhmdnd @jhrozek