Skip to content

Exclude MCO registry secret from integrity checks #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

rhmdnd
Copy link
Contributor

@rhmdnd rhmdnd commented Jul 10, 2024

We're noticing some issues in CI where tests time out because node never
reach their desired state. We've also noticed MCO making changes to a
file that was previously monitored, causing failures we weren't
expecting.

This commit attempts to fix the issue by excluding the MCO file in
question so it stops raising false negative results in the e2e suite.

We're noticing some issues in CI where tests time out because node never
reach their desired state. We've also noticed MCO making changes to a
file that was previously monitored, causing failures we weren't
expecting.

This commit attempts to fix the issue by excluding the MCO file in
question so it stops raising false negative results in the e2e suite.
@rhmdnd rhmdnd mentioned this pull request Jul 10, 2024
@rhmdnd rhmdnd requested a review from Vincent056 July 10, 2024 13:20
@openshift-ci openshift-ci bot requested a review from yuumasato July 10, 2024 13:20
Copy link
Contributor

openshift-ci bot commented Jul 10, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2024
@Vincent056
Copy link
Contributor

/lgtm
/retest

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 11, 2024
@Vincent056
Copy link
Contributor

We're noticing some issues in CI where tests time out because node never reach their desired state. We've also noticed MCO making changes to a file that was previously monitored, causing failures we weren't expecting.

This commit attempts to fix the issue by excluding the MCO file in question so it stops raising false negative results in the e2e suite.

https://redhat-internal.slack.com/archives/C02CZNQHGN8/p1720621801639479 we should be good to exclude that

Copy link
Contributor

openshift-ci bot commented Jul 11, 2024

@rhmdnd: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 67de2dc into openshift:master Jul 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants