-
Notifications
You must be signed in to change notification settings - Fork 27
OCPBUGS-36483: Fix new added node issue #607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Vincent056: This pull request references Jira Issue OCPBUGS-36483, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/etc/kubernetes/static-pod-resource is being created after a new node is being added, this cause the link count change in the aide checks and resulting a failures. The PR added a init pod to check for that before running aide daemonset.
dc35b5a
to
b3e8dc5
Compare
/label qe-approved |
fi`, | ||
}, | ||
SecurityContext: &corev1.SecurityContext{ | ||
Privileged: &priv, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need to be privileged? Or can we reduce the permissions required to run this container?
/retest |
@Vincent056: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thoughts on how we can protect this from regressions in CI?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I think this fixes the instability of the scaling e2e test @rhmdnd |
@Vincent056: Jira Issue OCPBUGS-36483: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-36483 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
/etc/kubernetes/static-pod-resource
is being created after a new node is added, this cause the link count change in the aide checks and resulting a failures. The PR added a init pod to check for that before running aide daemonset.