Skip to content

OCPBUGS-36483: Fix new added node issue #607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 17, 2025

Conversation

Vincent056
Copy link
Contributor

/etc/kubernetes/static-pod-resource is being created after a new node is added, this cause the link count change in the aide checks and resulting a failures. The PR added a init pod to check for that before running aide daemonset.

@openshift-ci-robot openshift-ci-robot added jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 21, 2024
@openshift-ci-robot
Copy link

@Vincent056: This pull request references Jira Issue OCPBUGS-36483, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/etc/kubernetes/static-pod-resource is being created after a new node is added, this cause the link count change in the aide checks and resulting a failures. The PR added a init pod to check for that before running aide daemonset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 21, 2024
/etc/kubernetes/static-pod-resource is being created after a new node is being added,
this cause the link count change in the aide checks and resulting a failures. The PR
added a init pod to check for that before running aide daemonset.
@xiaojiey
Copy link

/label qe-approved
The fileintegritynodestatus will be "Succeeded" for newly added nodes

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Nov 22, 2024
fi`,
},
SecurityContext: &corev1.SecurityContext{
Privileged: &priv,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be privileged? Or can we reduce the permissions required to run this container?

@Vincent056
Copy link
Contributor Author

/retest

Copy link
Contributor

openshift-ci bot commented Nov 27, 2024

@Vincent056: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-rosa 9acb863 link false /test e2e-rosa

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link
Contributor

@rhmdnd rhmdnd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thoughts on how we can protect this from regressions in CI?

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Dec 9, 2024
Copy link
Contributor

openshift-ci bot commented Dec 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Vincent056
Copy link
Contributor Author

Thoughts on how we can protect this from regressions in CI?

I think this fixes the instability of the scaling e2e test @rhmdnd

@Vincent056 Vincent056 merged commit cf60151 into openshift:master Jan 17, 2025
11 of 13 checks passed
@openshift-ci-robot
Copy link

@Vincent056: Jira Issue OCPBUGS-36483: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36483 has been moved to the MODIFIED state.

In response to this:

/etc/kubernetes/static-pod-resource is being created after a new node is added, this cause the link count change in the aide checks and resulting a failures. The PR added a init pod to check for that before running aide daemonset.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-moderate Referenced Jira bug's severity is moderate for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants