-
Notifications
You must be signed in to change notification settings - Fork 27
CMP-3362: Update bundle images for Red Hat registries #645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@rhmdnd: This pull request references CMP-3362 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
used
we might need to adjust the deployment image besides RELATED_IMAGE_OPERATOR |
I think the ICSP is working as expected when I manually created the deployment using redhat registry image:
ICSP in use are :
|
Updating the bundle upgrade job in openshift/release#64353 Should be able to work through those failures there. |
This commit updates the bundle build scripts so that it references images in registry.redhat.io, so that the bundle image will work once it's released. The images won't resolve, and we will use an ImageContentSourcePolicy to replace the image requests to registry.redhat.io with the quay.io references maintained by Konflux. The important part here is that we're using the same SHA as what's proposed in quay.io, so that when the image is mirrored the reference will resolve.
This will be more involved than just a Dockerfile image update. We'll need to think about how we can build bundle images in Konflux that reference the operator image from the PR, too. Not a blocker for this PR since we haven't tested that particular OpenShift operator bundle upgrade path in the past, but something we'll need to sketch out and implement after the 1.3.6 release. |
/test e2e-bundle-aws |
/lgtm
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd, Vincent056 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
a9abc7b
into
openshift:master
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This commit updates the bundle build scripts so that it references
images in registry.redhat.io, so that the bundle image will work once
it's released. The images won't resolve, and we will use an
ImageContentSourcePolicy to replace the image requests to
registry.redhat.io with the quay.io references maintained by Konflux.
The important part here is that we're using the same SHA as what's
proposed in quay.io, so that when the image is mirrored the reference
will resolve.