[release-4.16] OCPBUGS-55697: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs #6114

jparrill · 2025-05-05T10:10:06Z

What this PR does / why we need it

Manual backport of [release-4.17] OCPBUGS-55500, RHOCPPRIO-433: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs #6098

Which issue(s) this PR fixes

openshift-ci-robot · 2025-05-05T10:10:13Z

@jparrill: This pull request references Jira Issue OCPBUGS-55697, which is invalid:

expected dependent Jira Issue OCPBUGS-55500 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references RHOCPPRIO-433 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.z" version, but no target version was set.

In response to this:

What this PR does / why we need it

Manual backport of [release-4.17] OCPBUGS-55500, RHOCPPRIO-433: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs #6098

Which issue(s) this PR fixes

OCPBUGS-55697

RHOCPPRIO-433

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci · 2025-05-05T10:10:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jparrill

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jparrill]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2025-05-05T10:14:00Z

@jparrill: This pull request references Jira Issue OCPBUGS-55697, which is invalid:

expected dependent Jira Issue OCPBUGS-55500 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

This pull request references RHOCPPRIO-433 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the task to target the "4.16.z" version, but no target version was set.

In response to this:

What this PR does / why we need it

Manual backport of [release-4.17] OCPBUGS-55500, RHOCPPRIO-433: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs #6098

Bumped Go version from 1.22.0 to 1.22.1 in go.mod

Which issue(s) this PR fixes

OCPBUGS-55697

RHOCPPRIO-433

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2025-05-05T10:24:54Z

Looking at the log error:

GO111MODULE=on GOFLAGS=-mod=vendor go test -race -count=25 -timeout=30m ./... -coverprofile cover.out
go: go.mod requires go >= 1.22.1 (running go 1.21.13; GOTOOLCHAIN=local)
make: *** [Makefile:171: test] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-05-05T10:18:25Z"}

We need to move the Golang version (of 4.16, 4.15 and 4.14) to >= 1.22.1 in order to continue with this backport to all way long to release-4.14.

@sjenning WDYT?

go.mod

…r and NamedCertificates SANs This PR adds validation to ensure there are no conflicts between the SAN's of the user's APIServer NamedCertificates and the KubeAPIServer CPO certificates. This prevents potential issues with certificate SANs conflicts that could break the TLS trust chain between the nodes and the KAS Signed-off-by: Juan Manuel Parrilla Madrid <[email protected]>

jparrill · 2025-05-06T07:46:05Z

Looking at the log error:

GO111MODULE=on GOFLAGS=-mod=vendor go test -race -count=25 -timeout=30m ./... -coverprofile cover.out
go: go.mod requires go >= 1.22.1 (running go 1.21.13; GOTOOLCHAIN=local)
make: *** [Makefile:171: test] Error 1
{"component":"entrypoint","error":"wrapped process failed: exit status 2","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2025-05-05T10:18:25Z"}

We need to move the Golang version (of 4.16, 4.15 and 4.14) to >= 1.22.1 in order to continue with this backport to all way long to release-4.14.

@sjenning WDYT?

nvm, looks like there was an issue in my local with cache. All ok now

openshift-ci-robot · 2025-05-06T07:46:40Z

@jparrill: An error was encountered updating to the POST state for bug OCPBUGS-55697 on the Jira server at https://issues.redhat.com/. No known errors were detected, please see the full error message for details.

Full error message.


No response returned: Post "https://issues.redhat.com/rest/api/2/issue/16873217/transitions": POST https://issues.redhat.com/rest/api/2/issue/16873217/transitions giving up after 5 attempt(s)

Please contact an administrator to resolve this issue, then request a bug refresh with /jira refresh.

In response to this:

What this PR does / why we need it

Manual backport of [release-4.17] OCPBUGS-55500, RHOCPPRIO-433: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs #6098

Which issue(s) this PR fixes

OCPBUGS-55697

RHOCPPRIO-433

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

enxebre · 2025-05-06T08:57:57Z

/lgtm

jparrill · 2025-05-06T10:00:49Z

/retest

jparrill · 2025-05-06T13:09:53Z

/retest

jparrill · 2025-05-06T15:45:05Z

/test e2e-aws

jparrill · 2025-05-07T09:14:27Z

/retest

celebdor · 2025-05-07T13:06:48Z

/retitle [release-4.16] OCPBUGS-55697: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs

openshift-ci-robot · 2025-05-07T13:07:01Z

@jparrill: This pull request references Jira Issue OCPBUGS-55697, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target version (4.16.z) matches configured target version for branch (4.16.z)
bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
release note text is set and does not match the template
dependent bug Jira Issue OCPBUGS-55500 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
dependent Jira Issue OCPBUGS-55500 targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z
bug has dependents

Requesting review from QA contact:
/cc @wewang58

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it

Manual backport of [release-4.17] OCPBUGS-55500, RHOCPPRIO-433: Add validation to avoid conflicts between KubeAPIServer and NamedCertificates SANs #6098

Which issue(s) this PR fixes

OCPBUGS-55697

RHOCPPRIO-433

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

jparrill · 2025-05-08T08:21:54Z

/retest-required

openshift-ci-robot · 2025-05-08T15:44:55Z

/retest-required