Skip to content

CNTRLPLANE-833: Update KAS Deployment for Azure KMS for new Microsoft algorithm #6124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bryan-cox
Copy link
Member

@bryan-cox bryan-cox commented May 6, 2025

What this PR does / why we need it:
This PR updates the deployment for the KAS for Azure KMS to include the needed items for the new KMSv2 seed wrapping algorithm in https://github.com/Azure/kubernetes-kms/pull/408/files.

openshift/azure-kubernetes-kms#16 is needed in conjunction with this PR to have a fully working proof of concept (PoC).

Which issue(s) this PR fixes:
CNTRLPLANE-833

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 6, 2025

@bryan-cox: This pull request references CNTRLPLANE-833 which is a valid jira issue.

In response to this:

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 6, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 6, 2025
Copy link
Contributor

openshift-ci bot commented May 6, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci bot added do-not-merge/needs-area area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release labels May 6, 2025
Copy link
Contributor

openshift-ci bot commented May 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryan-cox

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels May 6, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2025

@bryan-cox: This pull request references CNTRLPLANE-833 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
This PR updates the deployment for the KAS for Azure KMS to include the needed items for the new KMSv2 seed wrapping algorithm in https://github.com/Azure/kubernetes-kms/pull/408/files.

openshift/azure-kubernetes-kms#16 is needed in conjunction with this PR to have a fully working proof of concept (PoC).

Which issue(s) this PR fixes:
CNTRLPLANE-833

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox changed the title CNTRLPLANE-833: WIP - still need to fix up the init container CNTRLPLANE-833: WIP - Update KAS Deployment for Azure KMS for new Microsoft algorithm May 8, 2025
@bryan-cox bryan-cox changed the title CNTRLPLANE-833: WIP - Update KAS Deployment for Azure KMS for new Microsoft algorithm CNTRLPLANE-833: Update KAS Deployment for Azure KMS for new Microsoft algorithm May 8, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2025

@bryan-cox: This pull request references CNTRLPLANE-833 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
This PR updates the deployment for the KAS for Azure KMS to include the needed items for the new KMSv2 seed wrapping algorithm in https://github.com/Azure/kubernetes-kms/pull/408/files.

openshift/azure-kubernetes-kms#16 is needed in conjunction with this PR to have a fully working proof of concept (PoC).

Which issue(s) this PR fixes:
CNTRLPLANE-833

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

1 similar comment
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 8, 2025

@bryan-cox: This pull request references CNTRLPLANE-833 which is a valid jira issue.

In response to this:

What this PR does / why we need it:
This PR updates the deployment for the KAS for Azure KMS to include the needed items for the new KMSv2 seed wrapping algorithm in https://github.com/Azure/kubernetes-kms/pull/408/files.

openshift/azure-kubernetes-kms#16 is needed in conjunction with this PR to have a fully working proof of concept (PoC).

Which issue(s) this PR fixes:
CNTRLPLANE-833

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bryan-cox bryan-cox force-pushed the CNTRLPLANE-833 branch 2 times, most recently from 82bfac4 to a2c1b43 Compare May 14, 2025 13:44
@openshift-ci openshift-ci bot added the area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release label May 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants