Skip to content

OCPBUGS-56249: fix lint-fix Makefile rule #6151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OCPBUGS-56249: fix lint-fix Makefile rule #6151

wants to merge 1 commit into from

Conversation

sdminonne
Copy link
Contributor

What this PR does / why we need it:

It fixes fix-lint Makefile dependencies and some typos

No unit-tests

@openshift-ci openshift-ci bot requested review from enxebre and sjenning May 13, 2025 14:53
@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/testing Indicates the PR includes changes for e2e testing and removed do-not-merge/needs-area labels May 13, 2025
@enxebre
Copy link
Member

enxebre commented May 13, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 13, 2025
@cwbotbot
Copy link

cwbotbot commented May 13, 2025 •
edited
Loading

Test Results

e2e-aws

e2e-aks

@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 14, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 14, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdminonne
Once this PR has been reviewed and has the lgtm label, please ask for approval from enxebre. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdminonne
Copy link
Contributor Author

Oups, sorry bad merge. Repushing

@openshift-ci openshift-ci bot added area/cli Indicates the PR includes changes for CLI area/documentation Indicates the PR includes changes for documentation labels May 14, 2025
@sdminonne sdminonne changed the title fix lint-deps and some typos fix lint-deps May 14, 2025
@sdminonne sdminonne changed the title fix lint-deps fix fix-lint deps May 14, 2025
@sdminonne
Copy link
Contributor Author

/retest-required

@sdminonne
Copy link
Contributor Author

@enxebre mind putting lgtm again?

@celebdor celebdor added area/ci-tooling Indicates the PR includes changes for CI or tooling and removed area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release area/documentation Indicates the PR includes changes for documentation area/cli Indicates the PR includes changes for CLI labels May 15, 2025
@celebdor celebdor removed the area/api Indicates the PR includes changes for the API label May 15, 2025
@sdminonne
OCPBUGS-56249: fix lint-fix rule
eaebb9d 
Signed-off-by: Salvatore Dario Minonne <[email protected]>
@sdminonne sdminonne changed the title fix fix-lint deps OCPBUGS-56249: fix lint-fix Makefile rule May 15, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 15, 2025
@openshift-ci-robot
Copy link

@sdminonne: This pull request references Jira Issue OCPBUGS-56249, which is invalid:

  • expected the bug to target the "4.20.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / why we need it:

It fixes fix-lint Makefile dependencies and some typos

No unit-tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@celebdor
Copy link
Collaborator

/jira refresh

@openshift-ci-robot openshift-ci-robot added the jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. label May 15, 2025
@openshift-ci-robot
Copy link

@celebdor: This pull request references Jira Issue OCPBUGS-56249, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot removed the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 15, 2025
@celebdor
Copy link
Collaborator

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link

@celebdor: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 15, 2025

@sdminonne: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@enxebre
Copy link
Member

enxebre commented May 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enxebre enxebre Awaiting requested review from enxebre

@sjenning sjenning Awaiting requested review from sjenning

Assignees

@enxebre enxebre

Labels
area/ci-tooling Indicates the PR includes changes for CI or tooling area/testing Indicates the PR includes changes for e2e testing jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sdminonne @enxebre @cwbotbot @openshift-ci-robot @celebdor @openshift-cherrypick-robot