-
Notifications
You must be signed in to change notification settings - Fork 373
OCPBUGS-53265: Use the image reference for the cache in the image metadata provider #6155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Skipping CI for Draft Pull Request. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ryan-cradick The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test e2e-aws-minimal |
6cd54dc
to
50175d8
Compare
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
/test e2e-aws-minimal |
50175d8
to
45b6b9b
Compare
Test Resultse2e-aws
e2e-aks
|
@ryan-cradick: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@ryan-cradick: This pull request references Jira Issue OCPBUGS-53265, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
// no further fetching occurs. Only if both cache lookups fail, the image metadata is fetched and | ||
// stored in the cache. | ||
// ImageMetadata returns metadata for a given image using the given pull secret to authenticate. | ||
// The ICSPs/IDMSs are checked first for overrides and then the cache is checked using the image |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: looks like you have "overrides and" when I expect you wanted a space "overrides and" instead of the tab. Same tab issue later in RegistryClientImageMetadataProvider.GetManifest
's Godocs. Maybe other places too; I haven't checked.
/jira refresh |
@celebdor: This pull request references Jira Issue OCPBUGS-53265, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
What this PR does / why we need it:
Allows release images to utilize tags (instead of a shah) and still utilize the image and image metadata caches.
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #OCPBUGS-53265
Checklist