Skip to content

METAL-1404: Make baremetal capability disabled by default on hosted clusters #6158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MahnoorAsghar
Copy link
Contributor

@MahnoorAsghar MahnoorAsghar commented May 15, 2025

Make baremetal capability disabled by default on hosted clusters

Fixes #METAL-1404

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 15, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2025

@MahnoorAsghar: This pull request references METAL-1404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Make baremetal capability disabled by default on hosted clusters

Fixes #METAL-1404: https://issues.redhat.com/browse/METAL-1404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2025

@MahnoorAsghar: This pull request references METAL-1404 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set.

In response to this:

Make baremetal capability disabled by default on hosted clusters

Fixes #METAL-1404

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from csrwng and hasueki May 15, 2025 10:46
@openshift-ci openshift-ci bot added area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI labels May 15, 2025
Copy link
Contributor

openshift-ci bot commented May 15, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MahnoorAsghar
Once this PR has been reviewed and has the lgtm label, please assign sjenning for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels May 15, 2025
@MahnoorAsghar
Copy link
Contributor Author

/jira refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented May 15, 2025

@MahnoorAsghar: This pull request references METAL-1404 which is a valid jira issue.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@cwbotbot
Copy link

cwbotbot commented May 15, 2025

Test Results

e2e-aws

e2e-aks

Failed Tests

Total failed tests: 5

  • TestNodePool
  • TestNodePool/HostedCluster0
  • TestNodePool/HostedCluster0/Main
  • TestNodePool/HostedCluster0/Main/TestNodePoolInPlaceUpgrade
  • TestNodePool/HostedCluster0/Main/TestNodepoolMachineconfigGetsRolledout

@MahnoorAsghar MahnoorAsghar force-pushed the disable-baremetal-cap-default branch 3 times, most recently from aa5aa1b to 644cc98 Compare May 16, 2025 14:03
@enxebre
Copy link
Member

enxebre commented May 19, 2025

Thanks @MahnoorAsghar! To reduce impact over already persisted resources and preserve control over defaults, baremetal will be disabled by default unless explicitly included in "enabled", but it doesn't need to be explicitly included in the "disabled". Let's close this PR and put a new one for the explicit opt-in implementation

@MahnoorAsghar MahnoorAsghar force-pushed the disable-baremetal-cap-default branch from 644cc98 to 6d31c47 Compare May 21, 2025 12:38
Copy link
Contributor

openshift-ci bot commented May 21, 2025

@MahnoorAsghar: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aks 6d31c47 link true /test e2e-aks
ci/prow/verify-deps 6d31c47 link true /test verify-deps
ci/prow/unit 6d31c47 link true /test unit
ci/prow/verify 6d31c47 link true /test verify

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/api Indicates the PR includes changes for the API area/cli Indicates the PR includes changes for CLI area/control-plane-operator Indicates the PR includes changes for the control plane operator - in an OCP release area/documentation Indicates the PR includes changes for documentation area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants