Skip to content

[release-4.18] OCPBUGS-56627: Do not validate OCP API Server SANS if PKI reconciliation is disabled #6186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 27, 2025
Merged

[release-4.18] OCPBUGS-56627: Do not validate OCP API Server SANS if PKI reconciliation is disabled #6186

merged 1 commit into from
May 27, 2025

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #6178

/assign openshift-cherrypick-robot

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request May 22, 2025
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56562 has been cloned as Jira Issue OCPBUGS-56627. Will retitle bug to link to clone.
/retitle [release-4.18] OCPBUGS-56627: Do not validate OCP API Server SANS if PKI reconciliation is disabled

In response to this:

This is an automated cherry-pick of #6178

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot changed the title [release-4.18] OCPBUGS-56562: Do not validate OCP API Server SANS if PKI reconciliation is disabled [release-4.18] OCPBUGS-56627: Do not validate OCP API Server SANS if PKI reconciliation is disabled May 22, 2025
@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels May 22, 2025
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-56627, which is invalid:

  • expected dependent Jira Issue OCPBUGS-56562 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is MODIFIED instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

This is an automated cherry-pick of #6178

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 22, 2025
@openshift-ci openshift-ci bot requested review from csrwng and enxebre May 22, 2025 18:54
@openshift-ci openshift-ci bot added area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release and removed do-not-merge/needs-area labels May 22, 2025
rtheis
rtheis approved these changes May 22, 2025
View reviewed changes
Copy link
Contributor

@rtheis rtheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2025
@rtheis
Copy link
Contributor

rtheis commented May 22, 2025

/retest

2 similar comments
@rtheis
Copy link
Contributor

rtheis commented May 23, 2025

/retest

@rtheis
Copy link
Contributor

rtheis commented May 23, 2025

/retest

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 23, 2025

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@rtheis
Copy link
Contributor

rtheis commented May 23, 2025

@jparrill ptal

@rtheis
Copy link
Contributor

rtheis commented May 23, 2025

@ryan-cradick please handle the Jira updates needed.

@enxebre
Copy link
Member

enxebre commented May 26, 2025

/approve

@enxebre enxebre added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. labels May 26, 2025
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented May 26, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enxebre, openshift-cherrypick-robot, rtheis

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2025
@rtheis
Copy link
Contributor

rtheis commented May 26, 2025

/jira refresh

@openshift-ci-robot
Copy link

@rtheis: This pull request references Jira Issue OCPBUGS-56627, which is invalid:

  • expected dependent Jira Issue OCPBUGS-56562 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@wangke19
Copy link

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 27, 2025
@openshift-ci-robot
Copy link

@wangke19: This pull request references Jira Issue OCPBUGS-56627, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.z) matches configured target version for branch (4.18.z)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-56562 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-56562 targets the "4.19.0" version, which is one of the valid target versions: 4.19.0
  • bug has dependents

Requesting review from QA contact:
/cc @wangke19

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from wangke19 May 27, 2025 04:19
@openshift-merge-bot openshift-merge-bot bot merged commit ab9649f into openshift:release-4.18 May 27, 2025
11 checks passed
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Jira Issue OCPBUGS-56627: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-56627 has been moved to the MODIFIED state.

In response to this:

This is an automated cherry-pick of #6178

/assign openshift-cherrypick-robot

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

Distgit: hypershift
This PR has been included in build ose-hypershift-container-v4.18.0-202505270504.p0.gab9649f.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rtheis rtheis rtheis approved these changes

@csrwng csrwng Awaiting requested review from csrwng

@enxebre enxebre Awaiting requested review from enxebre

@wangke19 wangke19 Awaiting requested review from wangke19

Assignees

@rtheis rtheis

@openshift-cherrypick-robot openshift-cherrypick-robot

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/hypershift-operator Indicates the PR includes changes for the hypershift operator and API - outside an OCP release backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @rtheis @enxebre @wangke19 @openshift-bot @ryan-cradick