-
Notifications
You must be signed in to change notification settings - Fork 375
AUTOSCALE-266: Refactor karpenter-operator and karpenter into v2 components #6187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUTOSCALE-266: Refactor karpenter-operator and karpenter into v2 components #6187
Conversation
@maxcao13: This pull request references AUTOSCALE-266 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Test Resultse2e-aws
e2e-aks
Failed TestsTotal failed tests: 9
... and 4 more failed tests |
control-plane-operator/controllers/hostedcontrolplane/v2/karpenteroperator/secret.go
Show resolved
Hide resolved
control-plane-operator/controllers/hostedcontrolplane/v2/karpenteroperator/secret.go
Show resolved
Hide resolved
control-plane-operator/controllers/hostedcontrolplane/v2/karpenteroperator/deployment.go
Outdated
Show resolved
Hide resolved
control-plane-operator/controllers/hostedcontrolplane/v2/karpenteroperator/component.go
Show resolved
Hide resolved
...l-plane-operator/controllers/hostedcontrolplane/v2/assets/karpenter-operator/deployment.yaml
Outdated
Show resolved
Hide resolved
db7ccdf
to
06a392e
Compare
control-plane-operator/controllers/hostedcontrolplane/v2/assets/karpenter/deployment.yaml
Outdated
Show resolved
Hide resolved
control-plane-operator/controllers/hostedcontrolplane/v2/assets/karpenter/deployment.yaml
Outdated
Show resolved
Hide resolved
control-plane-operator/controllers/hostedcontrolplane/v2/karpenter/role.go
Outdated
Show resolved
Hide resolved
karpenter-operator/controllers/karpenter/karpenter_controller.go
Outdated
Show resolved
Hide resolved
control-plane-operator/controllers/hostedcontrolplane/v2/karpenteroperator/component.go
Outdated
Show resolved
Hide resolved
can you please add the karpenter-operator component to |
Signed-off-by: Max Cao <[email protected]>
06a392e
to
006e2b5
Compare
/test e2e-aws-techpreview e2e-aws-karpenter-core |
@maxcao13: This pull request references AUTOSCALE-266 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This is probably no longer WIP, thanks for the review Mulham. +1 /cc @enxebre |
This commit refactors the karpenter deployment and assets which are managed by the karpenter operator to CPOv2. This removes the ability to pass in the karpenter aws image as an argument to the karpenter-operator deployment, since we can directly get the karpenter aws image from the payload image itself from within the karpenter-operator releaseImage lookup code. This commit also removes the deprecated karpenter code. Signed-off-by: Max Cao <[email protected]>
006e2b5
to
5d39a51
Compare
/test e2e-aws-techpreview The core tests are timing out, I think we need to up some of the timeouts on them in our karpenter fork. After changing it and running it locally, it seems to pass after increasing the timeouts. |
@maxcao13: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enxebre, maxcao13 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/override "Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main" |
@enxebre: Overrode contexts on behalf of enxebre: Red Hat Konflux / hypershift-operator-main-enterprise-contract / hypershift-operator-main In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
4c37875
into
openshift:main
[ART PR BUILD NOTIFIER] Distgit: hypershift |
What this PR does / why we need it:
This PR refactors the karpenter deployment and assets which are managed by the karpenter
operator to CPOv2. This removes the ability to pass in the karpenter aws image as an argument
to the karpenter-operator deployment, since we can directly get the karpenter aws image from
the payload image itself from within the karpenter-operator releaseImage lookup code. This
commit also removes the deprecated karpenter code.
Checklist