Skip to content

Add test for manifest migration #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2018
Merged

Add test for manifest migration #119

merged 1 commit into from
Aug 17, 2018

Conversation

dmage
Copy link
Contributor

@dmage dmage commented Aug 17, 2018

Closes #38.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2018
@dmage dmage force-pushed the manifestmigration branch from e42a2b1 to abdb056 Compare August 17, 2018 13:17
@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 17, 2018
@dmage dmage requested review from legionus and bparees and removed request for liggitt and miminar August 17, 2018 13:17
@dmage dmage force-pushed the manifestmigration branch from abdb056 to 188b39b Compare August 17, 2018 13:19
@dmage
Copy link
Contributor Author

dmage commented Aug 17, 2018

/retest

@dmage dmage force-pushed the manifestmigration branch from 188b39b to 5c9b8a9 Compare August 17, 2018 13:54
@dmage dmage changed the title [WIP] Add test for manifest migration Add test for manifest migration Aug 17, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 17, 2018
@bparees
Copy link
Contributor

bparees commented Aug 17, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 17, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, dmage

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 1bb6daa into openshift:master Aug 17, 2018
@dmage dmage deleted the manifestmigration branch August 18, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@legionus legionus Awaiting requested review from legionus

@bparees bparees Awaiting requested review from bparees

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dmage @bparees @openshift-ci-robot @openshift-merge-robot