Skip to content

<carry>: Enable VolumeAttributesClass tests in tech preview #2305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

<carry>: Enable VolumeAttributesClass tests in tech preview #2305

wants to merge 1 commit into from

Conversation

jsafrane
Copy link

The tests need VolumeAttributesClass feature gate enabled. Use [OCPFeatureGate:] to run them in TP jobs and skip them in all other jobs.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label May 20, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 20, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@jsafrane jsafrane marked this pull request as ready for review May 20, 2025 11:32
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 20, 2025
@jsafrane
Copy link
Author

/payload-job periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 20, 2025

@jsafrane: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/38540330-356e-11f0-9808-ef0669ebbfd8-0

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jsafrane
Once this PR has been reviewed and has the lgtm label, please assign jerpeter1 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot requested review from jerpeter1 and p0lyn0mial May 20, 2025 11:33
@jsafrane jsafrane mentioned this pull request May 20, 2025
Closed
stbenjam
stbenjam reviewed May 20, 2025
View reviewed changes
openshift-hack/e2e/annotate/rules.go Outdated
// and they will not run in all other jobs (where the gate is disabled).
"[OCPFeatureGate:VolumeAttributesClass]": {
`\[FeatureGate:VolumeAttributesClass\]`, // Disabled: beta upstream, enabled in OCP TechPreview feature set.
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Annotations are going away relatively soon #2299

You can write something alternatively to mutate the test name like this https://github.com/openshift/kubernetes/blob/master/openshift-hack/cmd/k8s-tests-ext/k8s-tests.go#L110-L114

@jsafrane
UPSTREAM: <carry>: Enable VolumeAttributesClass tests in tech preview
a76ac77 
The tests need VolumeAttributesClass feature gate enabled. Use
`[OCPFeatureGate:]` to enable them in TP jobs and disable them in all other
jobs.
@jsafrane jsafrane force-pushed the enable-volumeattributes-tests branch from 7a5eb3c to a76ac77 Compare May 21, 2025 12:28
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented May 21, 2025

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/k8s-e2e-gcp-serial a76ac77 link true /test k8s-e2e-gcp-serial
ci/prow/e2e-aws-ovn-runc a76ac77 link true /test e2e-aws-ovn-runc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@jsafrane
Copy link
Author

jsafrane commented May 22, 2025 •
edited
Loading

/hold
in favor of #2310

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stbenjam stbenjam stbenjam left review comments

@jerpeter1 jerpeter1 Awaiting requested review from jerpeter1

@p0lyn0mial p0lyn0mial Awaiting requested review from p0lyn0mial

Assignees
No one assigned
Labels
backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsafrane @openshift-ci-robot @stbenjam