Only reconcile owned deployments #424
Conversation
|
/hold |
openshift-ci-robot
added
do-not-merge/hold
|
Can you elaborate on why we wouldn't use an owner reference here? I'm actually surprised we don't already set one. |
|
if we do so we'd need to account for the case where the mao is running remotely/not as a deployment, so there's no owner to set, therefore needing different business logic for both cases and having skew. MAO is a special case in the sense that the controller itself is the owner, usually the controller creates a CRD resource instance which own things |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bison The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@enxebre: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Only reconcile owned deployments for update/delete events.
This would prevent other deployments in the
openshift-machine-apie.g autoscaler, mao deployment (owned by cvo) to trigger the reconciliation loop here.Opted by annotation rather than ownerRefs pointing to mao deployment as this would increase complexity and skew to contemplate reconciliation when the mao is running remotely