-
Notifications
You must be signed in to change notification settings - Fork 216
Vsphere #447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vsphere #447
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
I have not had a chance to run this yet to be honest, but it looks like a good start. I think we can merge this and unblock ourselves on further progress and testing.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bison The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@enxebre: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
This introduces a basic vSphere implementation and limited ability to create/update machines so we can follow up in a collaborative manner.
Logic for interacting with vCenter is mostly based from https://github.com/kubernetes-sigs/cluster-api-provider-vsphere
Tested with
and
Follow ups:
support userdata
support network/disk devices
set providerID