OCPBUGS-57072: configure-ovs: don't escape : in nmcli output
#5106
Conversation
nmcli --get-values will escape `:` and `\` by default.
This is because `:` is the normal key:value separator.
This escape breaks IPv6 output and MAC address output.
`src/nmcli/utils.c`
```c
if (nmc_config->print_output == NMC_PRINT_TERSE) {
if (nmc_config->escape_values) {
const char *p = text;
while (*p) {
if (*p == ':' || *p == '\\')
g_string_append_c(str, '\\'); /* Escaping by '\' */
g_string_append_c(str, *p);
p++;
}
} else
```
openshift-ci-robot
added
jira/severity-critical
|
@rbbratta: This pull request references Jira Issue OCPBUGS-57072, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Looks okay with IPv6 DNS. Jun 11 01:01:39 master-2 configure-ovs.sh[2992]: ++ nmcli --escape no --get-values ipv4.dns conn show 47985c50-3026-5b7c-a140-fdc2f2b62653
Jun 11 01:01:39 master-2 configure-ovs.sh[2497]: + ipv4_dns=192.168.111.1,192.168.111.22
Jun 11 01:01:39 master-2 configure-ovs.sh[2497]: + extra_if_brex_args+='ipv4.dns 192.168.111.1,192.168.111.22 '
Jun 11 01:01:39 master-2 configure-ovs.sh[2996]: ++ nmcli --escape no --get-values ipv6.dns conn show 47985c50-3026-5b7c-a140-fdc2f2b62653
Jun 11 01:01:39 master-2 configure-ovs.sh[2497]: + ipv6_dns=2001:4860:4860::8888
Jun 11 01:01:39 master-2 configure-ovs.sh[2497]: + extra_if_brex_args+='ipv6.dns 2001:4860:4860::8888 '
Jun 11 01:01:39 master-2 configure-ovs.sh[2497]: + add_nm_conn ovs-if-br-ex type ovs-interface slave-type ovs-port conn.interface br-ex master e3bcfafa-b0bd-4243-a856-1f594916d9f8 802-3-ethernet.mtu 1500 802-3-ethernet.cloned-mac-address 30:d0:42:56:66:c9 ipv4.method auto ipv4.route-metric 48 ipv6.method dhcp ipv6.route-metric 48 ipv4.may-fail no ipv4.dhcp-client-id mac ipv6.dhcp-duid ll ipv6.addr-gen-mode eui64 ipv4.dns 192.168.111.1,192.168.111.22 ipv6.dns 2001:4860:4860::8888 ipv4.ignore-auto-dns yes ipv6.ignore-auto-dns yes
Jun 11 01:01:39 master-2 configure-ovs.sh[2497]: + nmcli c add save no con-name ovs-if-br-ex type ovs-interface slave-type ovs-port conn.interface br-ex master e3bcfafa-b0bd-4243-a856-1f594916d9f8 802-3-ethernet.mtu 1500 802-3-ethernet.cloned-mac-address 30:d0:42:56:66:c9 ipv4.method auto ipv4.route-metric 48 ipv6.method dhcp ipv6.route-metric 48 ipv4.may-fail no ipv4.dhcp-client-id mac ipv6.dhcp-duid ll ipv6.addr-gen-mode eui64 ipv4.dns 192.168.111.1,192.168.111.22 ipv6.dns 2001:4860:4860::8888 ipv4.ignore-auto-dns yes ipv6.ignore-auto-dns yes connection.autoconnect no |
|
/jira refresh |
openshift-ci-robot
added
jira/valid-bug
|
@rbbratta: This pull request references Jira Issue OCPBUGS-57072, which is valid. The bug has been moved to the POST state. 3 validation(s) were run on this bug
Requesting review from QA contact: In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@openshift-ci-robot: GitHub didn't allow me to request PR reviews from the following users: rbbratta. Note that only openshift members and repo collaborators can review this PR, and authors cannot review their own PRs. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mkowalski, rbbratta, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
/retest-required |
|
/test ? |
|
@mkowalski: The following commands are available to trigger required jobs: The following commands are available to trigger optional jobs: Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/test e2e-metal-ipi-ovn-dualstack |
1 similar comment
|
/test e2e-metal-ipi-ovn-dualstack |
|
@rbbratta: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
bot
merged commit dbdfa3d
into
openshift:main
|
@rbbratta: Jira Issue OCPBUGS-57072: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-57072 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-machine-config-operator |
|
/label qe-approved |
openshift-ci
bot
added
the
qe-approved
|
@rbbratta: Jira Issue OCPBUGS-57072 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
nmcli --get-values will escape
:and\by default. This is because:is the normal key:value separator. This escape breaks IPv6 output and MAC address output.src/nmcli/utils.c