Skip to content

SECENGSP-6474: Fix failing enterprise contracts #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

sarroutbi
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 4, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 4, 2024

@sarroutbi: This pull request references SECENGSP-6474 which is a valid jira issue.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested a review from sergio-correia November 4, 2024 20:12
Copy link

openshift-ci bot commented Nov 4, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sarroutbi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2024
@sarroutbi sarroutbi removed the request for review from sergio-correia November 4, 2024 20:13
@sarroutbi sarroutbi force-pushed the 202411042054-fix-enterprise-contract-its branch from b594a9c to c895f4a Compare November 4, 2024 20:18
@sarroutbi
Copy link
Member Author

/retest

@sarroutbi sarroutbi force-pushed the 202411042054-fix-enterprise-contract-its branch 8 times, most recently from 24c121e to f64fdf5 Compare November 4, 2024 23:30
@sarroutbi sarroutbi added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label Nov 4, 2024
@sarroutbi
Copy link
Member Author

/retest

@sarroutbi sarroutbi force-pushed the 202411042054-fix-enterprise-contract-its branch from f64fdf5 to cfec997 Compare November 5, 2024 14:01
@sarroutbi
Copy link
Member Author

/retest

@sarroutbi sarroutbi force-pushed the 202411042054-fix-enterprise-contract-its branch 2 times, most recently from 83017c9 to adaef7f Compare November 6, 2024 09:01
Add allowed images from brew.registry.redhat.io

Signed-off-by: Sergio Arroutbi <[email protected]>
@sarroutbi sarroutbi force-pushed the 202411042054-fix-enterprise-contract-its branch from adaef7f to b02994a Compare November 6, 2024 10:41
@sarroutbi
Copy link
Member Author

Although enterprise contracts are failing, I will merge this. The reason is enterprise contracts seem to be pinned to previous SBOMS (as they are not considering changes in containers contained in this PR)

@sarroutbi sarroutbi merged commit b770acd into openshift:main Nov 6, 2024
19 of 30 checks passed
@sarroutbi sarroutbi deleted the 202411042054-fix-enterprise-contract-its branch November 6, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants