Add option to use cluster token instead password #251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarroutbi
requested changes
Jan 20, 2025
tools/cluster_tools/mirror_image.py
Outdated
| @@ -149,6 +153,15 @@ def launch_node_commands(node, api_server, args): | |||
| sys.stdout.flush() | |||
| child.close() | |||
|
|
|||
| def send_pexpect_command(child, command, prompt): | |||
There was a problem hiding this comment.
Please, don't create a new function while existing one makes this same.
If you want to decrease timeout to 60, use the existing one. You can reduce timeout if you wish there and include the message when the exception takes place.
|
/retest |
Koncpa
force-pushed
the
pk_add_token_mirror_image
branch
from
272ce76 to
6bd0cce
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Koncpa, sarroutbi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.