-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Updating to always configure api aggregation with installation #5363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating to always configure api aggregation with installation #5363
Conversation
aos-ci-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, seems like wire_aggregator could be made into its own role in the future.
/lgtm |
@ewolinetz: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/retest |
1 similar comment
/retest |
/retest |
2 similar comments
/retest |
/retest |
ff069ab
to
18efc8d
Compare
/test install |
@sdodson looks like all the tests passed on this. Do you want me to rebase down to one commit? |
18efc8d
to
2ed396b
Compare
/lgtm |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue |
This moves the wiring of the aggregator up into the config playbook as we want to enable this by default with an installation.
Resolves #5056