Ensure upgrades apply latest journald settings #5796
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, existing clusters might not have journald configurations applied. This may result in a rate- limiting of important log messages on openshift-masters. This commit ensures that journald settings are applied during the upgrade process openshif-masters. Fixes: openshift#5642
michaelgugino
added
kind/bug
openshift-ci-robot
added
the
size/M
|
bot, retest this please |
|
Thanks for picking this up! |
|
"Multiple deployment types running" /test install |
|
/test install |
|
/test install |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/test all |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
openshift-merge-robot
added a commit
to openshift/origin
that referenced
this pull request
Dec 6, 2017
Automatic merge from submit-queue (batch tested with PRs 17217, 17597, 17606). Remove journald limits @mfojtik this is dropping the hacks we had in place to tweak journald, now that ansible is doing it (openshift/openshift-ansible#3753 and openshift/openshift-ansible#5796). I'm additionally bringing back the deployments e2e's that were suffering from it. Let's see how far we can go with it. /cc @tnozicka Fixes #14785
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, existing clusters might not have journald
configurations applied. This may result in a rate-
limiting of important log messages on openshift-masters.
This commit ensures that journald settings are applied
during the upgrade process openshif-masters.
Fixes: #5642