Skip to content

Fix flake8 errors in utils/test #6488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 18, 2018

Conversation

vrutkovs
Copy link
Member

No description provided.

@openshift-ci-robot openshift-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 15, 2017
@michaelgugino
Copy link
Contributor

@vrutkovs Thank you for the pull request.

@sdodson Is this part of the code we wish to remove?

@sdodson
Copy link
Member

sdodson commented Dec 22, 2017 via email

@vrutkovs
Copy link
Member Author

vrutkovs commented Jan 4, 2018

Seems to be openshift/origin#14393

/retest

@vrutkovs
Copy link
Member Author

vrutkovs commented Jan 4, 2018

/retest

@michaelgugino michaelgugino removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 5, 2018
@vrutkovs
Copy link
Member Author

vrutkovs commented Jan 5, 2018

Test flakes - openshift/origin#12629, openshift/origin#16672
/retest

Copy link
Member

@mtnbikenc mtnbikenc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 18, 2018
@openshift-merge-robot
Copy link
Contributor

/test all [submit-queue is verifying that this PR is safe to merge]

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue.

@openshift-merge-robot openshift-merge-robot merged commit bccd1a8 into openshift:master Jan 18, 2018
@openshift-ci-robot
Copy link

@vrutkovs: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_conformance_install_crio 3ce40db link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@vrutkovs vrutkovs deleted the utils-test-flake8 branch January 5, 2019 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants