Don't hardcode the network interface in the openshift_logging_mux role #6609
Conversation
The openshift_logging_mux role hardcodes the 'eth0' interface alias for determining the IP address to use for incoming external client connections. This will cause the playbook to fail with an undefined variable error on systems where an 'eth0' interface does not exist. This patch changes the default IP address for external connections to use the 'ansible_default_ipv4' fact. It also allows this to be overridden by a new 'openshift_logging_mux_external_address' variable.
openshift-ci-robot
added
needs-ok-to-test
|
Can one of the admins verify this patch?
|
|
/ok-to-test |
openshift-ci-robot
removed
the
needs-ok-to-test
|
bot, test pull request |
|
@sdodson will |
The only situation where it wouldn't be is if the host has no default interface, this is a built in ansible fact so it gets set the first time facts are gathered. |
|
/retest |
1 similar comment
|
/retest |
|
/cherrypick release-3.8 |
|
@nkinder: only openshift org members may request cherry picks. You can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-3.7 |
|
@nkinder: only openshift org members may request cherry picks. You can still do the cherry-pick manually. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-3.7 |
|
@ewolinetz: once the present PR merges, I will cherry-pick it on top of release-3.7 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-3.8 |
|
@ewolinetz: once the present PR merges, I will cherry-pick it on top of release-3.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
conformance test error openshift/origin#17634 |
|
/retest |
|
bot, retest this please |
|
/lgtm |
|
bot, test pull request |
|
bot, retest this please |
|
@jlebon PTAL. Looks like the bot is not running for this specific PR yet it's blocking the ability to merge (as it should). |
|
FWIW I looked through the internal CI execution queue and don't see it; debugging this stuff is a huge pain since there's many legs in the chain that can go wrong in bridging the webhooks to fedmsg to the internal message bus to the internal jenkins. |
|
@cgwalters thanks for taking a look. @sdodson this seems to be an outlier in that fedmsg or another piece of infra flaked and so it's not showing up. If you're OK with it I suggest the force merge as PRs before and after this are being tested as they should be with the atomic bot. |
|
bot, retest this please |
|
I think this may be because @nkinder is not in the openshift or projectatomic org, which automatically whitelists all members. |
|
bot, add author to whitelist |
|
@jlebon @ewolinetz already tried whitelisting and asking to retest. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest |
|
@jlebon out of curiosity what changed? The bot's happy now but I don't see anything different via the comments. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue. |
|
@nkinder: new pull request created: #6689 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-3.7 |
|
@ewolinetz: new pull request created: #6690 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@nkinder: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
The openshift_logging_mux role hardcodes the 'eth0' interface alias
for determining the IP address to use for incoming external client
connections. This will cause the playbook to fail with an undefined
variable error on systems where an 'eth0' interface does not exist.
This patch changes the default IP address for external connections
to use the 'ansible_default_ipv4' fact. It also allows this to be
overridden by a new 'openshift_logging_mux_external_address' variable.