Skip to content

Detect config changes in console liveness probe #7032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 7, 2018

Conversation

spadgett
Copy link
Member

@spadgett spadgett commented Feb 6, 2018

Use an md5sum to check if the console config has changed and
automatically restart the container.

See openshift/origin#18411

/assign @sdodson
/cc @jwforres

Use an md5sum to check if the console config has changed and
automatically restart the container.
@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2018
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 6, 2018
@spadgett
Copy link
Member Author

spadgett commented Feb 6, 2018

/hold cancel
/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 6, 2018
@spadgett
Copy link
Member Author

spadgett commented Feb 6, 2018

/retest

@spadgett
Copy link
Member Author

spadgett commented Feb 6, 2018

/test logging

@spadgett
Copy link
Member Author

spadgett commented Feb 6, 2018

/retest

5 similar comments
@spadgett
Copy link
Member Author

spadgett commented Feb 6, 2018

/retest

@spadgett
Copy link
Member Author

spadgett commented Feb 6, 2018

/retest

@spadgett
Copy link
Member Author

spadgett commented Feb 7, 2018

/retest

@spadgett
Copy link
Member Author

spadgett commented Feb 7, 2018

/retest

@spadgett
Copy link
Member Author

spadgett commented Feb 7, 2018

/retest

@openshift-ci-robot
Copy link

@spadgett: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/logging 9c1cfde link /test logging
ci/openshift-jenkins/extended_conformance_install_crio 9c1cfde link /test crio

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@spadgett
Copy link
Member Author

spadgett commented Feb 7, 2018

@sdodson fyi, upstream template change has merged

@sdodson sdodson merged commit 178a71a into openshift:master Feb 7, 2018
@spadgett spadgett deleted the console-liveness branch February 7, 2018 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants