Disable mount propagation feature #7936
Conversation
| @@ -629,6 +629,7 @@ def build_controller_args(facts): | |||
| 'cloudprovider') | |||
| if 'master' in facts: | |||
| controller_args = {} | |||
| controller_args['feature-gates'] = 'MountPropagation=false' | |||
There was a problem hiding this comment.
Not sure if this was best place to add a controller argument. cc @sdodson
There was a problem hiding this comment.
Should be a list here: ['MountPropagation=false']. In any case, I don't think its needed, since its being set in l_node_kubelet_feature_flag_dict
There was a problem hiding this comment.
It looks like we have moved node flags to openshift_node/defaults/main.yml but master still relies on openshift_facts and this is required by both master and node configs.
|
This has to be done via master and node config or just one of them? |
|
This has to be done in both. |
|
bot, retest this |
|
bot, retest this please |
| @@ -629,6 +629,7 @@ def build_controller_args(facts): | |||
| 'cloudprovider') | |||
| if 'master' in facts: | |||
| controller_args = {} | |||
| controller_args['feature-gates'] = 'MountPropagation=false' | |||
There was a problem hiding this comment.
Should be a list here: ['MountPropagation=false']. In any case, I don't think its needed, since its being set in l_node_kubelet_feature_flag_dict
| @@ -652,6 +653,7 @@ def build_api_server_args(facts): | |||
| 'cloudprovider') | |||
| if 'master' in facts: | |||
| api_server_args = {} | |||
| api_server_args['feature-gates'] = 'MountPropagation=false' | |||
| @@ -82,12 +82,16 @@ openshift_node_kubelet_args_dict: | |||
|
|
|||
| l_node_kubelet_args_default: "{{ openshift_node_kubelet_args_dict[openshift_cloudprovider_kind | default('undefined')] }}" | |||
|
|
|||
| l_node_kubelet_feature_flag_dict: | |||
| feature-gates: | |||
| - "MountPropagation=false" | |||
There was a problem hiding this comment.
Travis wants 2 spaces here instead of 4
| @@ -82,12 +82,16 @@ openshift_node_kubelet_args_dict: | |||
|
|
|||
| l_node_kubelet_args_default: "{{ openshift_node_kubelet_args_dict[openshift_cloudprovider_kind | default('undefined')] }}" | |||
|
|
|||
| l_node_kubelet_feature_flag_dict: | |||
There was a problem hiding this comment.
No need to stick this in it's own dictionary and also modify l2 dict below.
Just put this feature-gates in the openshift_node_kubelet_args_dict. Or, we should refactor the common bits out of openshift_node_kubelet_args_dict.
We need to disable mount propagation feature in openshift-ansible for now becaue it breaks private mounts. We are changing the defaults in upstream to revert the feature to old behaviour
gnufied
force-pushed
the
disable-mount-propagation
branch
from
0b5c61c to
d0d30c9
Compare
openshift-ci-robot
added
the
size/XS
|
@vrutkovs @michaelgugino addressed review comments. Also added a reason why need to disable this feature. |
|
@gnufied What do you mean 'for now' ? Just for a week, or for 3.10, or for the foreseeable future? Will this break any current deployments? Does anything rely on this feature that we are disabling? How are we accounting for upgrades? |
|
@michaelgugino None of the existing stuff should break if we disable the feature. In future - I would like to make this tunable so as user can turn this on and off. May be - we should do this right now. I will try and make it so |
|
/hold |
openshift-ci-robot
added
the
do-not-merge/hold
|
Closing since openshift/origin#19364 is merged. |
We need to disable mount propagation feature in openshift-ansible for
now becaue it breaks private mounts. We are changing
the defaults in upstream to revert the feature to old behaviour
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1565625