add volume config generation #8450
Conversation
openshift-ci-robot
added
the
size/M
|
/assign @sdodson |
|
will defer to @sdodson but this looks good to merge after your other pr lands. |
|
/retest |
| dest: "{{ mktempout.stdout }}/volume-config.yaml" | ||
| when: | ||
| - configout.results.results.0 == {} and openshift_node_group_name != "" and openshift_node_local_quota_per_fsgroup is defined and openshift_node_local_quota_per_fsgroup != "" | ||
| run_once: true |
There was a problem hiding this comment.
run_once means that it will run only on the first node of a set of nodes. We'd want this file to get deployed to all relevant nodes, right?
There was a problem hiding this comment.
Nevermind, I should've read the entire PR before commenting.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson, sjenning The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
@sjenning: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Install job was successful, gcp problem is infrastructure limits. Merging. |
companion PR to openshift/origin#19773
adds
volume-config.yamlkey to node-config configmaps whenopenshift_node_local_quota_per_fsgroupis set.This results in the sync pod pulling down both
node-config.yamlandvolume-config.yamlinto/etc/origin/nodeso that the patched kubelet can read thevolume-config.yamlfile directly.@derekwaynecarr @smarterclayton @sdodson