-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Drop --confirm from migrate storage invocation #8781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This applies ONLY to 3.10 and higher, which is super important. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sdodson, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@enj fyi, since you authored the original PR |
LGTM as long as it can never be used with an older |
hmm, the pre-upgrade migration will run with 3.9 oc. I guess we should hold this until we branch release-3.10 and consider this for 3.11. It's just a warning of deprecation in 3.10, right? |
/hold |
Yeah the command just warns and ignores the user's input (confirm is always true). |
/hold cancel |
/retest |
@soltysh: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest |
Per openshift/origin#19691 drop the
--confirm
flag from storage migration operations./assign @sdodson @vrutkovs