OpenID/GitLab challenge options #2016
Conversation
|
@adellape ping |
|
LGTM, labeling for Future/enterprise-3.3 as I don't see the code in 3.2.1. |
|
[rev_history] |
| <2> When *true*, unauthenticated token requests from non-web clients (like | ||
| the CLI) are sent a `WWW-Authenticate` challenge header for this provider. | ||
| This uses the http://doc.gitlab.com/ce/api/oauth2.html#resource-owner-password-credentials[Resource Owner Password Credentials] | ||
| grant flow to obtain an access token from GitLab. | ||
| <2> *GitLabIdentityProvider* cannot be used to send `WWW-Authenticate` |
There was a problem hiding this comment.
@liggitt Sorry for bothering you, but I found out that this commits added two callouts with the same number. I mean there was <2> already and another one was added. I can provide a fix for this if you told me how (merge, remove previous or something else). Thanks.
There was a problem hiding this comment.
just open a new PR with the fix
There was a problem hiding this comment.
Definitely will open but I don't understand how it should be fixed :(
There was a problem hiding this comment.
open a PR removing the old <2> callout line
There was a problem hiding this comment.
Ok, I added the fix: ed5304b
Thank you!
added in openshift/origin#8732, post 1.2/3.2