Added storage to limits and quota #3084
Conversation
markturansky
force-pushed
the
add_storage_limits
branch
from
80fa5a6 to
03bf946
Compare
|
@markturansky Thanks! About labels though, what version of enterprise would this apply to? I can make a followup PR, but I don't want to put it in live docs if it's for future release. |
|
@bfallonf can you elaborate on labels? I'm not sure I know the answer to that. |
|
@markturansky we label PRs to indicate what branches the content should be cherrypicked to. I am assuming that this content should be introduced in the 3.4 docs since it aligns with Kube 1.4, so it should probably be marked for enterprise-3.4 and dedicated-3.4. Does that sound right? Thanks! |
|
@ahardin-rh yes, thanks for that clarification. I think that OSE 3.4 and Dedicated 3.4 sounds right. |
|
@markturansky Thanks! Labels are now set. |
|
Thanks for stepping in @ahardin-rh ! Yes, that's what I meant. @markturansky is this OK to merge? Does it need approval by anyone else? |
|
@bfallonf I suppose @derekwaynecarr can weigh in, but these are the same doc additions I made upstream that he approved there. |
| @@ -51,6 +51,11 @@ interchangeably. | |||
| exceed this value. `*memory*` and `*requests.memory*` are the same value and can | |||
| be used interchangeably. | |||
|
|
|||
| |`*storage*` | |||
There was a problem hiding this comment.
This is not accurate. ResourceQuota only supports requests.storage
| spec: | ||
| hard: | ||
| persistentvolumeclaims: "10" <1> | ||
| storage: "50Gi" <2> |
There was a problem hiding this comment.
make this requests.storage.
markturansky
force-pushed
the
add_storage_limits
branch
from
03bf946 to
f4aab7e
Compare
| @@ -51,6 +51,11 @@ interchangeably. | |||
| exceed this value. `*memory*` and `*requests.memory*` are the same value and can | |||
| be used interchangeably. | |||
|
|
|||
| |`*requests.storage*` | |||
There was a problem hiding this comment.
we can remove this and avoid listing the same value twice ;-)
There was a problem hiding this comment.
fixed. not paying attention...
markturansky
force-pushed
the
add_storage_limits
branch
from
f4aab7e to
7b1e7a0
Compare
|
@markturansky @derekwaynecarr OK. Thanks, all. I'll merge away! |
|
[rev_history] |
Storage was added to Quota in Kube 1.4.
Limits are being cherry picked via openshift/origin#11396
@derekwaynecarr @abhgupta