Skip to content

Do not use comma-separated template parameters #3107

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mmilata
Copy link

@mmilata mmilata commented Oct 25, 2016

Replace

oc new-app --param X=Y,Z=W
oc process --value X=Y,Z=W

with

oc new-app --param X=Y --param Z=W
oc process --value X=Y --value Z=W

because the former will likely be removed from oc in openshift/origin#11539.

Replace

  oc new-app --param X=Y,Z=W
  oc process --value X=Y,Z=W

with

  oc new-app --param X=Y --param Z=W
  oc process --value X=Y --value Z=W

because the former will likely be removed from oc.
@bparees
Copy link
Contributor

bparees commented Oct 25, 2016

lgtm

@openshift/team-documentation ptal, this can be merged after openshift/origin#11539 goes in.

@vikram-redhat
Copy link
Contributor

@ahardin-rh - ptal.

@ahardin-rh ahardin-rh added this to the Future Release milestone Oct 26, 2016
@ahardin-rh ahardin-rh self-assigned this Oct 26, 2016
@ahardin-rh ahardin-rh changed the title Do not use comma-separated template parameters [DoNotMerge]Do not use comma-separated template parameters Oct 26, 2016
@ahardin-rh
Copy link
Contributor

LGTM. Marking as Do Not Merge until openshift/origin#11539 is merged.

@mmilata
Copy link
Author

mmilata commented Oct 27, 2016

The scope of openshift/origin#11539 has been extended to -e/--env args as well. I've opened new PR for the documentation changes because this one is already reviewed. Let me know if you'd prefer to have it in this PR instead and I'll add it.

@mmilata
Copy link
Author

mmilata commented Nov 2, 2016

@openshift/team-documentation openshift/origin#11539 has been merged. Can you please merge this as well as #3123?

@ahardin-rh ahardin-rh changed the title [DoNotMerge]Do not use comma-separated template parameters Do not use comma-separated template parameters Nov 2, 2016
@ahardin-rh ahardin-rh merged commit 6551b60 into openshift:master Nov 2, 2016
@ahardin-rh
Copy link
Contributor

No revision history needed (formatting fixes)

@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging, OCP 3.4 GA Jan 16, 2017
@adellape adellape modified the milestones: OCP 3.4 GA, Staging Feb 1, 2017
@adellape adellape modified the milestones: Temp, Staging, OCP 3.4 GA Feb 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants