Added documentation for adding Docker build args. #3694
Conversation
|
lgtm, assuming of course that you get api approval for the api shown in the example :) |
bparees
changed the title
dev_guide/builds.adoc
Outdated
| [[docker-strategy-build-args]] | ||
| === Docker Build Arguments | ||
|
|
||
|
|
There was a problem hiding this comment.
Just remove one extra line here. The rest LGTM! 🍻
|
@oatmealraisin Whoops! Heads-up that this will have to be rebased since the Builds topic was just reworked into smaller chunks. Looks like you will want to move this new section to the Build Strategies file https://docs.openshift.com/container-platform/3.4/dev_guide/builds/build_strategies.html 👁️🗨️ |
|
@ahardin-rh Thanks for the heads up! |
bparees
changed the title
|
@oatmealraisin bump |
|
@ahardin-rh Moved everything to Build Strategies, ptal? @bparees The content didn't change. |
| === Docker Build Arguments | ||
|
|
||
| To set link:http://docs.docker.com/v1.7/reference/api/hub_registry_spec/#docker-registry-1-0[Docker build arguments] | ||
| , add entries to the `BuildArgs` array, which is located in the |
There was a problem hiding this comment.
Overall, this looks great! My one nit is that it looks like a weird line break here. Other than that, I think we're ready to go. Thanks!
There was a problem hiding this comment.
Sorry, I break on >80 characters, fixed
|
Thank you! |
|
[rev_history] |
Short section on Build Args. @bparees ptal?
Waiting on the related PR in Origin