Shuffle endpoints using new env var for template router #4320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @ahardin-rh |
ahardin-rh
reviewed
May 17, 2017
| @@ -246,6 +246,8 @@ $ oc set env dc/router ROUTER_SYSLOG_ADDRESS=127.0.0.1 ROUTER_LOG_LEVEL=debug | |||
| |`*RELOAD_SCRIPT*` | | The path to the reload script to use to reload the router. | |||
| |`*ROUTER_ALLOWED_DOMAINS*` | | A comma-separated list of domains that the host name in a route can only be part of. Any subdomain in the domain can be used. Option `ROUTER_DENIED_DOMAINS` overrides any values given in this option. If set, everything outside of the allowed domains will be rejected. | |||
| |`*ROUTER_BACKEND_CHECK_INTERVAL*` | 5000ms | Length of time between subsequent "liveness" checks on backends. xref:time-units[(TimeUnits)] | |||
| |`*ROUTER_BACKEND_PROCESS_ENDPOINTS*` | | String to specify how the endpoints should be processed while using the template function | |||
| processEndpointsForAlias. Valid values are ["shuffle", ""]. "shuffle" will randomize the elements upon every call. Default behaviour returns in pre-determined order. | |||
|
@rajatchopra Is this targeting OCP 3.6? Thanks! Also waiting on openshift/origin#14008 to merge |
|
@rajatchopra Is this still valid? Looks like we need a rebase. Thanks! |
…n now be shuffled on each reload. A new env var is introduced to select the processing choice (only one option 'shuffle' today).
|
@ahardin-rh Still valid. Cleaned and rejigged. Thanks. |
|
@rajatchopra Thanks! What versions does this apply to? 3.6 and onward, or can it be applied to 3.4 and onward? |
|
3.6 for sure. Will open another PR/issue if this needs to be made valid for 3.4 or earlier. |
|
[rev_history] |
ahardin-rh
pushed a commit
to ahardin-rh/openshift-docs
that referenced
this pull request
Oct 25, 2017
…proxy template can now be shuffled on each reload. A new env var is introduced to select the processing choice (only one option 'shuffle' today). (cherry picked from commit 4c5480f) xref:openshift#4320
ahardin-rh
pushed a commit
to ahardin-rh/openshift-docs
that referenced
this pull request
Oct 25, 2017
…proxy template can now be shuffled on each reload. A new env var is introduced to select the processing choice (only one option 'shuffle' today). (cherry picked from commit 4c5480f) xref:openshift#4320
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of origin PR 14008, the server list of an haproxy template can now be shuffled on each reload. A new env var is introduced to select the processing choice (only one option 'shuffle' today).
@knobunc @pecameron PTAL