Skip to content

document OPENSHIFT-ADMIN-OUTPUT-RULES #4490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2017

Conversation

danwinship
Copy link
Contributor

Document the new iptables chain that exists for admin special purposes.
openshift/origin#14221 / https://trello.com/c/dnZHuI5R
@openshift/networking

Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean docs. Thanks. I flagged it enterprise-3.6 since I don't think we are back-porting this, right?

@danwinship
Copy link
Contributor Author

isn't 3.6 still in the future and "backporting" would be 3.5?
but we haven't backported the upstream code yet anyway...

@knobunc
Copy link
Contributor

knobunc commented May 25, 2017

@danwinship -- right. I just wanted to make sure the docs end up in the correct release for where the feature is going. 3.6 has not been released and is what we are working on at the moment.

automatically, but it does provide a place where such rules can be
added manually by the administrator. Each node, on startup, will
create an empty chain called `OPENSHIFT-ADMIN-OUTPUT-RULES` in the
`filter` table (assuming that that chain doesn't already exist). Any

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming that chain?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/doesn't/does not

Copy link

@pravisankar pravisankar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -32,6 +32,13 @@ not impact the operation of {product-title} and the Docker service. Also, change
will often need to be made on all nodes in the cluster. Use caution, as iptables
is not designed to have multiple concurrent users and it is very easy to break
{product-title} and Docker networking.

{product-title} provides one chain which is specifically intended for
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chain, which

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a comma implies (to me) that openshift only provides one chain (and that chain is intended for administrators to use). But it creates many chains, it's just that only one of them has this purposes.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danwinship @ahardin-rh I'd agree with Ashley. Commas are really only for separating clauses. I'd suggest "OpenShift provides a number of chains, one of which is specifically intended for..."

I was asked to have a look at this PR and see if it needed a followup and this is the only thought I had. I'll do that.

@@ -435,6 +440,44 @@ $ oc create -f <replication_controller>.json
oc describe rc <replication_controller>
----

[[admin-guide-limit-pod-access-iptables]]
=== Using iptables rules to Limit Access to External Resources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rules

=== Using iptables rules to Limit Access to External Resources

Some cluster administrators may want to perform actions on outgoing
traffic that don't fit within the model of EgressNetworkPolicy or the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/don't/do not

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`EgressNetworkPolicy`

. The rules are not applied to traffic that exits the cluster via an
egress-router, and they run after EgressNetworkPolicies are applied
(and so will not see traffic that is denied by an
EgressNetworkPolicy).
Copy link
Contributor

@ahardin-rh ahardin-rh May 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

`EgressNetworkPolicy`

automatically.

. The rules are not applied to traffic that exits the cluster via an
egress-router, and they run after EgressNetworkPolicies are applied
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

egress router

@ahardin-rh ahardin-rh added this to the Future Release milestone May 26, 2017
@danwinship danwinship force-pushed the admin-iptables-filtering branch from 6c20657 to 63b4d3b Compare May 31, 2017 13:58
@danwinship
Copy link
Contributor Author

updated with all the other suggested changes

@danwinship
Copy link
Contributor Author

github thinks this is still running in travis, but travis says it passed...

@ahardin-rh ahardin-rh merged commit 0d8d7ab into openshift:master Jun 20, 2017
@bfallonf bfallonf mentioned this pull request Jul 6, 2017
@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging Jul 7, 2017
@vikram-redhat vikram-redhat modified the milestones: Future Release, Staging Aug 9, 2017
@vikram-redhat vikram-redhat modified the milestones: Staging, Future Release, OCP 3.6 GA Aug 9, 2017
@danwinship danwinship deleted the admin-iptables-filtering branch November 16, 2017 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants