-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Added document for labeling AWS resources on clusters #5732
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
FYI, @kwoodson track this as the docs to reference when someone attempts to upgrade an untagged cluster. |
Amazon Web Services (AWS). | ||
|
||
In order to correctly identify which resources are associated to a cluster, resources | ||
should be tagged with the key `KubernetesCluster`. Tagging all resources with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's move to the newer style of labeling:
key: kubernetes.io/cluster/<somestr>
value: clusterid
The KubernetesCluster is deprecated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fine with the newer labeling style so long as that is what the installer will check for and ensure is set. The source material was updating KubernetesCluster. Is the installer checking for the new or old style? @sdodson
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For environments where the hosts are pre-provisioned we're merely checking that they've told us a cluster id. The installer has never required that variable be set previously so this will halt clean 3.7 installs and upgrades with a reference to this documentation so they can address the issue then set the variable as a signal to us that it's safe to proceed.
For environments where openshift-ansible provisions the hosts we tag using the new style.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, then for consistency is makes sense to use the new style for these docs. I will update
78512db
to
5e1abb8
Compare
@kwoodson PTAL |
Continuing this work in #6237 |
No description provided.