Update log6x-oc-explain.adoc #93678
Update log6x-oc-explain.adoc #93678
Conversation
openshift-ci
bot
added
the
size/XS
|
🤖 Thu May 22 17:49:18 - Prow CI generated the docs preview: |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
|
@amandverma, same comment as in: #93675 (review) |
jab-rh
added
peer-review-done
Changed type information for lokistacks.loki.grafana.com.spec.size from integer to string Update log6x-oc-explain.adoc improving grammar
|
@amandverma: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
skopacz1
added
the
peer-review-in-progress
| @@ -49,7 +49,7 @@ For example: | |||
| $ oc explain lokistacks.loki.grafana.com.spec.size | |||
| ---- | |||
|
|
|||
| This will show that `size` should be defined using an integer value. | |||
| This output shows that the `size` field must be set to a string value. | |||
|
|
|||
| == Default Values | |||
There was a problem hiding this comment.
I would recommend doing this in another PR if it's something that you want to change, but in either case this is out of scope and up to you - I notice that none of these second level headings have IDs on them, which they should have.
If this is something you want to fix in another PR, I would go through this file and make sure every heading has an ID, like this:
| == Default Values | |
| [id="default-values_{context}"] | |
| == Default Values |
skopacz1
added
branch/enterprise-4.14
and removed
peer-review-in-progress
Changed type information for lokistacks.loki.grafana.com.spec.size from integer to string
lokistacks.loki.grafana.com.spec.size should be defined using an string valueVersion(s):
4.14Issue:
https://issues.redhat.com/browse/OBSDOCS-1887Link to docs preview:
https://93678--ocpdocs-pr.netlify.app/openshift-enterprise/latest/observability/logging/logging-6.0/log6x-upgrading-to-6.htmlQE review:
Additional information: