OBSDOCS-1941: Update storage-persistent-storage-reclaim-manual.adoc #93724
Conversation
openshift-ci
bot
added
the
size/XS
|
/label peer-review-needed |
openshift-ci
bot
added
the
peer-review-needed
abrennan89
added
peer-review-in-progress
abrennan89
changed the title
openshift-ci-robot
added
the
jira/valid-reference
|
@prithvipatil97: This pull request references OBSDOCS-1941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note: please link directly to the module that has been updated in previews, e.g. |
abrennan89
added
peer-review-done
- one variable needs to be updated with underscores instead of hyphens. - Here is the documentation: https://docs.redhat.com/en/documentation/openshift_container_platform/4.16/html/storage/understanding-persistent-storage#reclaim-manual_understanding-persistent-storage Here is the current documentation: 1. Delete the PV. $ oc delete pv <pv-name> Here `<pv-name> ` is mentioned with `underscores`. But as per the standard format, it should be with `hyphens`. Also, `full stop` is mentioned after `Delete the PV.`, but `colon` ( is required here. Here is the updated look: 1. Delete the PV: ~~~ $ oc delete pv <pv_name> ~~~ New-Update modules/storage-persistent-storage-reclaim-manual.adoc Here is the current documentation: 1. Delete the PV. ~~~ $ oc delete pv <pv-name> ~~~ - Here `<pv-name> ` is mentioned with `hyphens`. - But as per the standard format, it should be with `underscores`. - Also, `full stop` is mentioned after `Delete the PV.`, but `colon` (:) is required here. Here is the updated look: 1. Delete the PV by running the following command: ~~~ $ oc delete pv <pv_name> ~~~ Co-authored-by: Ashleigh Brennan <[email protected]>
|
@prithvipatil97: This pull request references OBSDOCS-1941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@prithvipatil97: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Hello Team, All checks have passed, and Peer review is also done. It would be really helpful if someone could please take a look and provide QE approval for this change. Regards, |
|
@prithvipatil97: This pull request references OBSDOCS-1941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@prithvipatil97 I don't think that QE is required for this PR, since it doesn't change the meaning of the docs. However, for future PRs that require QE or SME reviews, please reach out to your engineering and QE team directly, since the OCP docs team are not responsible for coordinating these. |
|
@prithvipatil97 if you need this PR to be merged, please follow the process to Request for a PR to be merged |
|
/label merge-review-needed |
openshift-ci
bot
added
the
merge-review-needed
|
/lgtm |
|
@prithvipatil97: This pull request references OBSDOCS-1941 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
ShaunaDiaz
removed
the
merge-review-needed
|
@prithvipatil97 All PRs against |
|
/cherrypick enterprise-4.13 |
|
/cherrypick enterprise-4.14 |
|
/cherrypick enterprise-4.15 |
|
/cherrypick enterprise-4.16 |
|
/cherrypick enterprise-4.17 |
|
/cherrypick enterprise-4.18 |
|
/cherrypick enterprise-4.19 |
|
/cherrypick enterprise-4.20 |
|
@ShaunaDiaz: new pull request created: #95258 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #95259 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #95260 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #95261 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #95262 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #95263 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #95264 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ShaunaDiaz: new pull request created: #95265 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Here is the current documentation:
<pv-name>is mentioned withhyphens.underscores.full stopis mentioned afterDelete the PV., butcolon(:) is required here.Here is the updated look:
Version(s):
RHOCP 4.19, RHOCP 4.18, RHOCP 4.17, RHOCP 4.16, RHOCP 4.15, RHOCP 4.14, RHOCP 4.13
Issue:
https://issues.redhat.com/browse/OBSDOCS-1941
Link to docs preview:
https://93724--ocpdocs-pr.netlify.app/microshift/latest/microshift_storage/understanding-persistent-storage-microshift.html
https://93724--ocpdocs-pr.netlify.app/openshift-dedicated/latest/storage/understanding-persistent-storage.html
https://93724--ocpdocs-pr.netlify.app/openshift-enterprise/latest/storage/understanding-persistent-storage.html
https://93724--ocpdocs-pr.netlify.app/openshift-rosa-hcp/latest/storage/understanding-persistent-storage.html
https://93724--ocpdocs-pr.netlify.app/openshift-rosa/latest/storage/understanding-persistent-storage.html
QE review:
Approved
Additional information: