This repository was archived by the owner on Jul 25, 2019. It is now read-only.
Removed the cookies from the remote node rules. #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| otx.AddFlow("table=8, cookie=0x%s, priority=100, ip, nw_dst=%s, actions=move:NXM_NX_REG0[]->NXM_NX_TUN_ID[0..31],set_field:%s->tun_dst,output:1", cookie, nodeSubnetCIDR, nodeIP) | ||
| otx.AddFlow("table=1, cookie=0x0, priority=100, tun_src=%s, actions=goto_table:5", nodeIP) | ||
| otx.AddFlow("table=8, cookie=0x0, priority=100, arp, nw_dst=%s, actions=move:NXM_NX_REG0[]->NXM_NX_TUN_ID[0..31],set_field:%s->tun_dst,output:1", nodeSubnetCIDR, nodeIP) | ||
| otx.AddFlow("table=8, cookie=0x0, priority=100, ip, nw_dst=%s, actions=move:NXM_NX_REG0[]->NXM_NX_TUN_ID[0..31],set_field:%s->tun_dst,output:1", nodeSubnetCIDR, nodeIP) |
There was a problem hiding this comment.
If we are not setting cookie, we don't have to specify it right?
otx.AddFlow("table=8, priority=100, ...)
|
LGTM |
|
LGTM after ravi's comments. |
knobunc
force-pushed
the
feature/remove-cookies
branch
2 times, most recently
from
ea6768f to
07aa19e
Compare
| otx.AddFlow("table=8, cookie=0x%s, priority=100, ip, nw_dst=%s, actions=move:NXM_NX_REG0[]->NXM_NX_TUN_ID[0..31],set_field:%s->tun_dst,output:1", cookie, subnet.Subnet, subnet.HostIP) | ||
| otx.AddFlow("table=1, priority=100, tun_src=%s, actions=goto_table:5", cookie, subnet.HostIP) | ||
| otx.AddFlow("table=8, priority=100, arp, nw_dst=%s, actions=move:NXM_NX_REG0[]->NXM_NX_TUN_ID[0..31],set_field:%s->tun_dst,output:1", cookie, subnet.Subnet, subnet.HostIP) | ||
| otx.AddFlow("table=8, priority=100, ip, nw_dst=%s, actions=move:NXM_NX_REG0[]->NXM_NX_TUN_ID[0..31],set_field:%s->tun_dst,output:1", cookie, subnet.Subnet, subnet.HostIP) |
There was a problem hiding this comment.
you need to remove the cookie from the argument lists too
The rest of the ovs sdn rules had removed them in other patches. This catches the other cases we hadn't cleaned up.
knobunc
force-pushed
the
feature/remove-cookies
branch
from
07aa19e to
6b1643a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rest of the ovs sdn rules had removed them in other patches. This catches the other cases we hadn't yet changed.