This repository was archived by the owner on Jul 25, 2019. It is now read-only.
Return better errors from SetUpPod/TearDownPod #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously when errors occured in SetUpPod(), we ended up logging just "exit status 1" (unless we were running at --loglevel=5). Fix that. This also switches the code to use os/exec directly rather than kubernetes's wrapper, so we can check the return error type. (Kubernetes's exec wraps the error in a private type.)
| return err | ||
|
|
||
| if isScriptError(err) { | ||
| return fmt.Errorf("Error running network setup script: %s", getScriptError(out)) |
There was a problem hiding this comment.
Can you also include pod name and namespace in the error msg? I think that will be useful.
There was a problem hiding this comment.
kubernetes adds that when it logs the error:
message := fmt.Sprintf("Failed to setup network for pod %q using network plugins %q: %v; Skipping pod", format.Pod(pod), dm.networkPlugin.Name(), err)
where format.Pod(pod) outputs fmt.Sprintf("%s_%s(%s)", pod.Name, pod.Namespace, pod.UID)
|
Minor comment, LGTM overall |
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #290
@openshift/networking PTAL