This repository was archived by the owner on Jul 25, 2019. It is now read-only.
Add more HostSubnet logging #296
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcbw
force-pushed
the
more-hostsubnet-logging
branch
from
e7e0ad2 to
76ab6f4
Compare
| @@ -51,6 +51,8 @@ type OsdnController struct { | |||
| // Called by plug factory functions to initialize the generic plugin instance | |||
| func (oc *OsdnController) BaseInit(registry *Registry, pluginHooks PluginHooks, multitenant bool, hostname string, selfIP string) error { | |||
|
|
|||
| log.Infof("Starting with configured hostname '%s' (IP '%s')", hostname, selfIP) | |||
|
|
|||
There was a problem hiding this comment.
We are already logging hostname/selfIP in https://github.com/dcbw/openshift-sdn/blob/more-hostsubnet-logging/plugins/osdn/common.go#L77-L79
There was a problem hiding this comment.
Yeah, but that's after the fixups. I'd like to see what the configured/command-line values are too.
We don't expect nodes to be added/removed very often so the log spam won't be large.
dcbw
force-pushed
the
more-hostsubnet-logging
branch
from
76ab6f4 to
42142b1
Compare
|
LGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't expect nodes to be added/removed very often so the log
spam won't be large.