Add origin common modal popup component. #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Aug 1, 2017
| {{$ctrl.modalTitle}} | ||
| </h4> | ||
| <div ng-transclude></div> | ||
| <a href="" class="origin-modal-popup-close" ng-click="$ctrl.onClose()()"> |
There was a problem hiding this comment.
Are the extra parens intentional because of how we are passing the callback? If so, worth a comment in case someone "fixes" it.
There was a problem hiding this comment.
Not necessary, I've fixed it.
| var leftPos; | ||
| var elementRect = positionElement.getBoundingClientRect(); | ||
| var windowHeight = $window.innerHeight; | ||
| var modalElement = angular.element($element)[0].children[0]; |
There was a problem hiding this comment.
Does $element[0].children[0] work without the angular.element()?
There was a problem hiding this comment.
It does, I've removed it.
rhamilto
approved these changes
Aug 1, 2017
dtaylor113
approved these changes
Aug 1, 2017
This was referenced Aug 2, 2017
|
Minor change for binding type of on-close (& to <) for consistency. |
|
@spadgett Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate from origin-web-catalog and make more generic.