Updates for edit-project and create-project components #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
reviewed
Aug 8, 2017
| showAlert({ | ||
| type: "error", | ||
| NotificationsService.addNotification({ | ||
| id: 'edit-project-error', |
There was a problem hiding this comment.
We probably want to put the project name in the ID. Otherwise if you edit two different projects and get errors for both, you'll only see the first toast notification and not the second.
There was a problem hiding this comment.
Decided just to remove the IDs. User could potentially try twice and not see the second notification.
Also updated notification messages and Logger'd failures.
No longer used in full pages so remove the btn-lg and input-lg classes and remove the alerts parameters
spadgett
approved these changes
Aug 9, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No longer used in full pages so remove the btn-lg and input-lg classes and remove the alerts parameters
Fixes #142
Fixes #143