Skip to content

Update npm dependencies to match origin-web-console repo #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 19, 2018

Conversation

benjaminapetersen
Copy link
Contributor

@benjaminapetersen benjaminapetersen commented Feb 14, 2018

Per earlier conversation with @jwforres, this should solve the 3 items we listed.

In addition:

  • new dist generated since this bumps our uglify plugin
  • had to eliminate the space_colon option from the Gruntfile as it is no longer supported & grunt build failed
  • note: our minify JS for console and common are a bit different in the Gruntfile due to usemin, but the options match now.
  • jasmine-core must now be explicitly declared

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 14, 2018
@spadgett
Copy link
Member

It looks like npm install failed in travis. @benjaminapetersen can you take a look?

@benjaminapetersen
Copy link
Contributor Author

yup checking it out

@benjaminapetersen
Copy link
Contributor Author

Bumped nodejs to 6 in travis to match console, tests now pass.

Copy link
Member

@spadgett spadgett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Please hold off on a common release until we merge #304

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 19, 2018
@spadgett spadgett merged commit 5ea67be into openshift:master Feb 19, 2018
@spadgett
Copy link
Member

Hm, grunt build failing for me now because it can't launch Chrome :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants