Switch to code authorization flow #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spadgett
approved these changes
Apr 24, 2017
dist/origin-web-common-services.js
Outdated
| // Handle an error response from the OAuth server | ||
| if (params.error) { | ||
| var error_description = params.error_description; | ||
| var error_uri = params.error_uri; |
There was a problem hiding this comment.
This is a nit, but it's odd to have local vars for these two and not params.error. Also I generally avoid var declarations inside an if since they're not block scope. Suggest using params.error_description without the local vars.
dist/origin-web-common-services.js
Outdated
| then: stateData.then, | ||
| verified: stateData.verified | ||
| }); | ||
| return deferred.promise; |
There was a problem hiding this comment.
This could be
if (params.access_token) {
return $q.when({
token: params.access_token,
...
});
}
|
updated |
jeff-phillips-18
approved these changes
Apr 24, 2017
liggitt
commented
Apr 24, 2017
dist/origin-web-common-services.js
Outdated
| @@ -2893,7 +2908,37 @@ angular.module('openshiftCommonServices') | |||
| // Returns a promise that resolves with {token:'...',then:'...',verified:true|false}, or rejects with {error:'...'[,error_description:'...',error_uri:'...']} | |||
| // If no token and no error is present, resolves with {} | |||
| // Example error codes: https://tools.ietf.org/html/rfc6749#section-5.2 | |||
| finish: function() { | |||
| finish: function($http) { | |||
There was a problem hiding this comment.
agree it's gorpy to require this here... @spadgett was looking into avoiding this
spadgett
approved these changes
Apr 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches to code authorization flow to avoid OAuth redirects containing access tokens.
Lays the groundwork for adding PKCE support to the web console.
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1430456