Skip to content

Update APIService.apiInfo to return verbs when possible #77

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2017

Conversation

benjaminapetersen
Copy link
Contributor

For last task on this trello card.
PR to origin-web-console coming soon depending on this change.

hostPort: api.hostPort,
prefix: api.prefix,
version: resource.version,
namespaced: discoveredResource.namespaced
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why arent you getting the verbs here as well, im looking at the api discovery on my machine and i get verbs on these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not getting verbs, but let me check, maybe i wan't on latest origin.

Copy link
Contributor Author

@benjaminapetersen benjaminapetersen May 23, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, i get them now. ok will update, my bad.

@benjaminapetersen
Copy link
Contributor Author

Updated, added tests & updated fixtures (& fixed a broken DataService test)

- also add APIService.kindToResourceGroupVersion
- update APIService tests
- update DataService tests that fail after fixture update
@benjaminapetersen
Copy link
Contributor Author

[test]

@jwforres jwforres merged commit 489271d into openshift:master May 23, 2017
@benjaminapetersen benjaminapetersen deleted the api-info-verbs branch May 24, 2017 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants