Update APIService.apiInfo to return verbs when possible #77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwforres
reviewed
May 23, 2017
src/services/apiService.js
Outdated
| hostPort: api.hostPort, | ||
| prefix: api.prefix, | ||
| version: resource.version, | ||
| namespaced: discoveredResource.namespaced |
There was a problem hiding this comment.
why arent you getting the verbs here as well, im looking at the api discovery on my machine and i get verbs on these
There was a problem hiding this comment.
I was not getting verbs, but let me check, maybe i wan't on latest origin.
There was a problem hiding this comment.
Yup, i get them now. ok will update, my bad.
benjaminapetersen
force-pushed
the
api-info-verbs
branch
from
5e5a53d to
2b1cb35
Compare
|
Updated, added tests & updated fixtures (& fixed a broken DataService test) |
jeff-phillips-18
approved these changes
May 23, 2017
- also add APIService.kindToResourceGroupVersion - update APIService tests - update DataService tests that fail after fixture update
benjaminapetersen
force-pushed
the
api-info-verbs
branch
from
2b1cb35 to
da199af
Compare
|
[test] |
jwforres
approved these changes
May 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For last task on this trello card.
PR to origin-web-console coming soon depending on this change.